> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It!
What was the verdict? Is it just a matter of an updated patch description/summary and then this should be pushed? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9316 ----------------------------------------------------------- On Jan. 24, 2017, 4:33 p.m., Alec Roelke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3781/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2017, 4:33 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11796:1c03f7dcaa8c > --------------------------- > riscv: Remove ECALL tests from insttest > > The system calls tested in rv64i.cpp in RISC-V's insttest suite have > different behavior depending on the operating system and file system they > are run on. This patch removes those tests from the regression. > > [Change deletion of ECALL test to block comment.] > [Restore ECALL test but remove test output to test only for completion > without error.] > > > Diffs > ----- > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.ini > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.json > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simerr > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simout > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/stats.txt > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.ini > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.json > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simerr > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simout > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/stats.txt > 97eebddaae84 > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/config.ini > 97eebddaae84 > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/config.json > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simerr > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simout > 97eebddaae84 > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/stats.txt > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.ini > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.json > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simerr > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simout > 97eebddaae84 > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/stats.txt > 97eebddaae84 > > Diff: http://reviews.gem5.org/r/3781/diff/ > > > Testing > ------- > > > Thanks, > > Alec Roelke > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
