> On Jan. 25, 2017, 11:28 a.m., Andreas Sandberg wrote: > > Ship It! > > Andreas Hansson wrote: > What was the verdict? Is it just a matter of an updated patch > description/summary and then this should be pushed? > > Andreas Sandberg wrote: > Yes, the description needs to be updated. I'm not sure what happened to > the placeholder files in the test directories. Instead of the simulator > output, there should be an empty file called EMPTY in the output directory to > make sure that it is created by the VCS. It's not showing up in the raw diff, > so I suspect it wasn't added to the commit. Another possibility is that RB/HG > is silly, which wouldn't be the first time. > > Alec Roelke wrote: > I just updated the patch with a new description. My local version of the > patch correctly creates EMPTY files in the linux-rv64i output directory, but > I still don't see them here.
The EMPTY file thing is definitely and issue with reviewboard. You're not doing anything wrong, Alec. :) We can coordinate off-list on me getting the right patch, and I'll push it. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3781/#review9316 ----------------------------------------------------------- On Feb. 13, 2017, 3 p.m., Alec Roelke wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3781/ > ----------------------------------------------------------- > > (Updated Feb. 13, 2017, 3 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11808:1c38f8e541ba > --------------------------- > riscv: Remove ECALL tests from insttest > > The system calls tested in rv64i.cpp in RISC-V's insttest suite have > different behavior depending on the operating system and file system they > are run on. This patch ignores the output of those tests and only > ensures that the instructions in RV64I complete successfully. > > [Change deletion of ECALL test to block comment.] > [Restore ECALL test but remove test output to test only for completion > without error.] > [Update patch description and again try to push EMPTY files for rv64i > tests.] > > > Diffs > ----- > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simout > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/simerr > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.ini > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/config.json > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.json > 63325e5b0a9d > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/stats.txt > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/config.ini > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.ini > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/config.json > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simerr > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/simout > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-atomic/stats.txt > 63325e5b0a9d > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/config.ini > 63325e5b0a9d > > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/config.json > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simerr > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing-ruby/simout > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/minor-timing/stats.txt > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simerr > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/simout > 63325e5b0a9d > tests/quick/se/02.insttest/ref/riscv/linux-rv64i/simple-timing/stats.txt > 63325e5b0a9d > > Diff: http://reviews.gem5.org/r/3781/diff/ > > > Testing > ------- > > > Thanks, > > Alec Roelke > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
