----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9437 -----------------------------------------------------------
Thanks for writing formalising this! There are some really minor nits below. You might want to consider renaming this to CONTRIBUTING.md to make sure that it renders nicely in tool GUIs (e.g., GitHub) that understand markdown. CONTRIBUTING (line 10) <http://reviews.gem5.org/r/3814/#comment7957> Typo CONTRIBUTING (line 19) <http://reviews.gem5.org/r/3814/#comment7958> Typo: Delete 'use'. CONTRIBUTING (line 29) <http://reviews.gem5.org/r/3814/#comment7959> It might be worth adding a paragraph to explain the why there are both reviewers and maintainers ackign changes here. CONTRIBUTING (line 157) <http://reviews.gem5.org/r/3814/#comment7961> Since we are switching to Gerrit, we should just state something along these lines: "You generally don't need to add these manually as they are added automatically by Gerrit." CONTRIBUTING (line 160) <http://reviews.gem5.org/r/3814/#comment7962> "Added automatically by Gerrit" CONTRIBUTING (line 162) <http://reviews.gem5.org/r/3814/#comment7963> We might want to specify that this is added automatically by a commit hook in git. CONTRIBUTING (line 166) <http://reviews.gem5.org/r/3814/#comment7964> We might want to move the second half of this paragraph to the description of signed-off-by above. CONTRIBUTING (line 213) <http://reviews.gem5.org/r/3814/#comment7965> The first slash in /refs/for/... isn't needed. I'm not sure if it breaks anything though. - Andreas Sandberg On Feb. 16, 2017, 4:54 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3814/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2017, 4:54 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 11849:b5f456096b51 "misc: Add a CONTRIBUTING document > > This document details how to contribute to gem5 based on our new > contribution flow with git and gerrit. > > Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" > > > Diffs > ----- > > CONTRIBUTING PRE-CREATION > > Diff: http://reviews.gem5.org/r/3814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
