----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9500 -----------------------------------------------------------
Several of us have discussed this document at AMD and we have a few more questions and comments below. I assume reviewboard is the best place to continue this conversation since this patch has not been moved to Gerrit. CONTRIBUTING.md (line 34) <http://reviews.gem5.org/r/3814/#comment7994> Can we add the Gerrit testing before the code is posted for review? Reviewers should know that the code passes before they review it. CONTRIBUTING.md (line 55) <http://reviews.gem5.org/r/3814/#comment7993> What happens when a maintainer has not been assigned to a region of code? Is there a way even to guarantee that all existing portions of the code have a maintainer assigned? It seems like we should say if there is a maintainer, then one must get their approval. However in situations where one has not been assigned, we should skip this step. CONTRIBUTING.md (line 293) <http://reviews.gem5.org/r/3814/#comment7992> Restricting maintainer to be PMC member seems too restrictive. When someone contributes large portions of the code (especially code that adds new features) the contributor will likely be the best person to maintain the code. - Brad Beckmann On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3814/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 5:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 11849:b5f456096b51 "misc: Add a CONTRIBUTING document > > This document details how to contribute to gem5 based on our new > contribution flow with git and gerrit. > > Signed-off-by: Jason Lowe-Power <ja...@lowepower.com>" > > > Diffs > ----- > > CONTRIBUTING.md PRE-CREATION > > Diff: http://reviews.gem5.org/r/3814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list gem5-dev@gem5.org http://m5sim.org/mailman/listinfo/gem5-dev
