----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3824/#review9478 -----------------------------------------------------------
Thanks for catching this bug. I'm now a bit surprised this code work correctly before. I have a couple questions/comments below. The most important is possibly missing "max_outstanding_request" line. Other than that, this patch looks good to me and points out we have more items to fix. src/mem/ruby/system/GPUCoalescer.py (line 50) <http://reviews.gem5.org/r/3824/#comment7983> This patch points out that we really should not have an icache or IFETCHes as part of the GPUCoalescer. It is designed to only handle data accesses from the GPU CUs. You don't necessarily need to remove this line and make all the other necessary changes, but if you don't, we'll get someone from AMD to make that change. src/mem/ruby/system/GPUCoalescer.py (line 52) <http://reviews.gem5.org/r/3824/#comment7984> Aren't you missing the following line: max_outstanding_requests = Param.Int(16, "max requests (incl. prefetches) outstanding") - Brad Beckmann On Feb. 22, 2017, 9:28 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3824/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 9:28 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11878:b0a4f3815b55 > --------------------------- > gpu-compute: Fix Python/C++ object hierarchy discrepancies > > The GPUCoalescer and the Shader classes have different base classes in > C++ and Python. This causes subtle bugs in SWIG and compilation errors > for PyBind. > > Change-Id: I1ddd2a8ea43f083470538ddfea891347b21d14d8 > Reviewed-by: Andreas Hansson <[email protected]> > > > Diffs > ----- > > src/gpu-compute/shader.hh ba90ffa751b6 > src/gpu-compute/shader.cc ba90ffa751b6 > src/mem/ruby/system/GPUCoalescer.hh ba90ffa751b6 > src/mem/ruby/system/GPUCoalescer.py ba90ffa751b6 > > Diff: http://reviews.gem5.org/r/3824/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
