> On March 2, 2017, 4:52 p.m., Brad Beckmann wrote: > > Not sure why this patch now shows as discarded, but please ship it.
I discarded it and moved it to gerrit (https://gem5-review.googlesource.com/#/c/2228/) since it didn't have any ship it at the time. Could you add your ship it there as well so it is kept in the review record? - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3824/#review9498 ----------------------------------------------------------- On Feb. 22, 2017, 9:28 a.m., Andreas Sandberg wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3824/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2017, 9:28 a.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > Changeset 11878:b0a4f3815b55 > --------------------------- > gpu-compute: Fix Python/C++ object hierarchy discrepancies > > The GPUCoalescer and the Shader classes have different base classes in > C++ and Python. This causes subtle bugs in SWIG and compilation errors > for PyBind. > > Change-Id: I1ddd2a8ea43f083470538ddfea891347b21d14d8 > Reviewed-by: Andreas Hansson <[email protected]> > > > Diffs > ----- > > src/gpu-compute/shader.hh ba90ffa751b6 > src/gpu-compute/shader.cc ba90ffa751b6 > src/mem/ruby/system/GPUCoalescer.hh ba90ffa751b6 > src/mem/ruby/system/GPUCoalescer.py ba90ffa751b6 > > Diff: http://reviews.gem5.org/r/3824/diff/ > > > Testing > ------- > > > Thanks, > > Andreas Sandberg > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
