> On March 2, 2017, 10:56 p.m., Brad Beckmann wrote: > > CONTRIBUTING.md, line 55 > > <http://reviews.gem5.org/r/3814/diff/2/?file=66037#file66037line55> > > > > What happens when a maintainer has not been assigned to a region of > > code? Is there a way even to guarantee that all existing portions of the > > code have a maintainer assigned? > > > > It seems like we should say if there is a maintainer, then one must get > > their approval. However in situations where one has not been assigned, we > > should skip this step.
I think we need some way of tracking maintainers on a per file/directory basis. Linux has a similar system in place (see the MAINTAINERS file). In addition to component/architecture maintainers, I expect we'll end up with a set of core maintainers that are responsible for shared functionality and ACKs unmaintained bits. > On March 2, 2017, 10:56 p.m., Brad Beckmann wrote: > > CONTRIBUTING.md, line 34 > > <http://reviews.gem5.org/r/3814/diff/2/?file=66037#file66037line34> > > > > Can we add the Gerrit testing before the code is posted for review? > > Reviewers should know that the code passes before they review it. AFAIK, there is no easy way to get gerrit to run the regressions before publishing a review. One possibility would be to submit a draft review and wait for Jenkins to run and then publish the review. The problem with that approach is that (automatically) assigned reviewers typically get notifications for draft reviews. In my experience, this isn't a large problem. > On March 2, 2017, 10:56 p.m., Brad Beckmann wrote: > > CONTRIBUTING.md, line 293 > > <http://reviews.gem5.org/r/3814/diff/2/?file=66037#file66037line293> > > > > Restricting maintainer to be PMC member seems too restrictive. When > > someone contributes large portions of the code (especially code that adds > > new features) the contributor will likely be the best person to maintain > > the code. Good point. I think we might need to move in this direction to avoid scalability issues going forwards. - Andreas ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.gem5.org/r/3814/#review9500 ----------------------------------------------------------- On Feb. 21, 2017, 5:34 p.m., Jason Lowe-Power wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.gem5.org/r/3814/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 5:34 p.m.) > > > Review request for Default. > > > Repository: gem5 > > > Description > ------- > > changesets: > 11849:b5f456096b51 "misc: Add a CONTRIBUTING document > > This document details how to contribute to gem5 based on our new > contribution flow with git and gerrit. > > Signed-off-by: Jason Lowe-Power <[email protected]>" > > > Diffs > ----- > > CONTRIBUTING.md PRE-CREATION > > Diff: http://reviews.gem5.org/r/3814/diff/ > > > Testing > ------- > > > Thanks, > > Jason Lowe-Power > > _______________________________________________ gem5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/gem5-dev
