Jason Lowe-Power has submitted this change and it was merged. (
https://gem5-review.googlesource.com/8861 )
Change subject: mem-cache: Fix missing overrides
......................................................................
mem-cache: Fix missing overrides
clang doesn't like inconsistent overrides. Add override to all overidden
functions in lru.hh
Change-Id: I100ff4a7d90757439afee879ff9838c15f5c0b1d
Signed-off-by: Jason Lowe-Power <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/8861
Reviewed-by: Gabe Black <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Nikos Nikoleris <[email protected]>
---
M src/mem/cache/tags/lru.hh
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
Gabe Black: Looks good to me, approved
diff --git a/src/mem/cache/tags/lru.hh b/src/mem/cache/tags/lru.hh
index 530b07a..1fbe4eb 100644
--- a/src/mem/cache/tags/lru.hh
+++ b/src/mem/cache/tags/lru.hh
@@ -69,9 +69,9 @@
*/
~LRU() {}
- CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat);
- CacheBlk* findVictim(Addr addr);
- void insertBlock(PacketPtr pkt, BlkType *blk);
+ CacheBlk* accessBlock(Addr addr, bool is_secure, Cycles &lat) override;
+ CacheBlk* findVictim(Addr addr) override;
+ void insertBlock(PacketPtr pkt, BlkType *blk) override;
void invalidate(CacheBlk *blk) override;
};
--
To view, visit https://gem5-review.googlesource.com/8861
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I100ff4a7d90757439afee879ff9838c15f5c0b1d
Gerrit-Change-Number: 8861
Gerrit-PatchSet: 2
Gerrit-Owner: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerit-CC: Daniel Carvalho <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
