MadMaurice has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/12686 )
Change subject: Pl011: Added registers UART_RSR/UART_ECR
......................................................................
Pl011: Added registers UART_RSR/UART_ECR
UART_RSR shows errors with the transmission and UART_ECR can clear
those (according to PL011 Technical Reference Manual Revision r1p4). As
these transmission errors never occur, they are implemented as RAZ/WI.
Both registers exist at the same offset 0x004. RSR is read-only, ECR is
write-only.
Signed-off-by: Maurice Becker <[email protected]>
Change-Id: Ia9d13c90c65feccf3ecec36a782170755b1e1c02
Reviewed-on: https://gem5-review.googlesource.com/12686
Reviewed-by: Andreas Sandberg <[email protected]>
Maintainer: Andreas Sandberg <[email protected]>
---
M src/dev/arm/pl011.cc
M src/dev/arm/pl011.hh
2 files changed, 7 insertions(+), 0 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
diff --git a/src/dev/arm/pl011.cc b/src/dev/arm/pl011.cc
index e47cc67..5ca9f60 100644
--- a/src/dev/arm/pl011.cc
+++ b/src/dev/arm/pl011.cc
@@ -92,6 +92,9 @@
}
}
break;
+ case UART_RSR:
+ data = 0x0; // We never have errors
+ break;
case UART_FR:
data =
UART_FR_CTS | // Clear To Send
@@ -205,6 +208,8 @@
clearInterrupts(UART_TXINTR);
raiseInterrupts(UART_TXINTR);
break;
+ case UART_ECR: // clears errors, ignore
+ break;
case UART_CR:
control = data;
break;
diff --git a/src/dev/arm/pl011.hh b/src/dev/arm/pl011.hh
index 2317b31..5a92d88 100644
--- a/src/dev/arm/pl011.hh
+++ b/src/dev/arm/pl011.hh
@@ -118,6 +118,8 @@
protected: // Registers
static const uint64_t AMBA_ID = ULL(0xb105f00d00341011);
static const int UART_DR = 0x000;
+ static const int UART_RSR = 0x004;
+ static const int UART_ECR = 0x004;
static const int UART_FR = 0x018;
static const int UART_FR_CTS = 0x001;
static const int UART_FR_RXFE = 0x010;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/12686
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ia9d13c90c65feccf3ecec36a782170755b1e1c02
Gerrit-Change-Number: 12686
Gerrit-PatchSet: 6
Gerrit-Owner: MadMaurice <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: MadMaurice <[email protected]>
Gerrit-CC: Jason Lowe-Power <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
