Gabe Black has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/13455 )
Change subject: mem: Expose the raw packet accessor functions.
......................................................................
mem: Expose the raw packet accessor functions.
This avoids a place where data has its endianness switched so that when
the endianness based accessors switch it back it returns to normal. It
also makes it easier to show intent when accessing single bytes where
endianness doesn't matter, and there's no contextual endianness.
Change-Id: I1b97396c1b9bb39727d35112d90e3969e5fe0aab
Reviewed-on: https://gem5-review.googlesource.com/c/13455
Reviewed-by: Andreas Sandberg <[email protected]>
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Nikos Nikoleris <[email protected]>
---
M src/mem/packet.hh
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Nikos Nikoleris: Looks good to me, approved; Looks good to me, approved
diff --git a/src/mem/packet.hh b/src/mem/packet.hh
index 0f45a7b..515dcc7 100644
--- a/src/mem/packet.hh
+++ b/src/mem/packet.hh
@@ -1077,9 +1077,11 @@
template <typename T>
void set(T v, ByteOrder endian);
+#if THE_ISA != NULL_ISA
/** Set the value in the data pointer to v as guest endian. */
template <typename T>
void set(T v);
+#endif
/**
@@ -1173,7 +1175,6 @@
/** @} */
- private: // Private data accessor methods
/** Get the data in the packet without byte swapping. */
template <typename T>
T getRaw() const;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/13455
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I1b97396c1b9bb39727d35112d90e3969e5fe0aab
Gerrit-Change-Number: 13455
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Alec Roelke <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
