Bagus Hanindhito has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/16522 )
Change subject: x86: Call the base class's regStats in X86ISA::TLB
......................................................................
x86: Call the base class's regStats in X86ISA::TLB
When I try to build x86 architecture and run the se.py sample script
with helloworld example, there is a panic warning stated "Not all stats
have been initialized. You may need to add <ParentClass>::regStats() to
a new SimObject's regStats() function."
I see that in x86 tlb.cc, there is no initialization in regStats() function
that causes memory allocation error in some machine which make gem5 exit
abnormally. I add the BaseTLB::regStats(); on TLB::regStats() method and
can solve the problem
Change-Id: I8b62bebc15f896c3136ff4f8253dabbf998f618f
Reviewed-on: https://gem5-review.googlesource.com/c/16522
Reviewed-by: Gabe Black <[email protected]>
Maintainer: Gabe Black <[email protected]>
---
M src/arch/x86/tlb.cc
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gabe Black: Looks good to me, approved; Looks good to me, approved
diff --git a/src/arch/x86/tlb.cc b/src/arch/x86/tlb.cc
index 589b2b7..829ebce 100644
--- a/src/arch/x86/tlb.cc
+++ b/src/arch/x86/tlb.cc
@@ -455,7 +455,7 @@
TLB::regStats()
{
using namespace Stats;
-
+ BaseTLB::regStats();
rdAccesses
.name(name() + ".rdAccesses")
.desc("TLB accesses on read requests");
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/16522
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I8b62bebc15f896c3136ff4f8253dabbf998f618f
Gerrit-Change-Number: 16522
Gerrit-PatchSet: 4
Gerrit-Owner: Bagus Hanindhito <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Bagus Hanindhito <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
