Hello John Alsop,
I'd like you to reexamine a change. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/17539
to look at the new patch set (#5).
Change subject: mem: Improve DPRINTF for Packets
......................................................................
mem: Improve DPRINTF for Packets
When printing Packet data, DPRINTF accesses internal information
and prints them, however this is unreliable, since the internals
of Packet can change. As Packet provides a print function, make
use of it when suitable instead.
Change-Id: I6b5010e3ef146c3a18a55f779999e78a119bb9db
Signed-off-by: Daniel R. Carvalho <[email protected]>
---
M src/mem/abstract_mem.cc
M src/mem/bridge.cc
M src/mem/cache/base.cc
M src/mem/cache/cache.cc
M src/mem/cache/noncoherent_cache.cc
M src/mem/cache/prefetch/queued.cc
M src/mem/dram_ctrl.cc
M src/mem/dramsim2.cc
M src/mem/external_slave.cc
M src/mem/hmc_controller.cc
M src/mem/noncoherent_xbar.cc
M src/mem/packet_queue.cc
M src/mem/qos/mem_sink.cc
M src/mem/ruby/system/RubyPort.cc
M src/mem/ruby/system/Sequencer.cc
M src/mem/serial_link.cc
16 files changed, 91 insertions(+), 117 deletions(-)
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/17539
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I6b5010e3ef146c3a18a55f779999e78a119bb9db
Gerrit-Change-Number: 17539
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: Daniel Carvalho <[email protected]>
Gerrit-Reviewer: John Alsop <[email protected]>
Gerrit-CC: Nikos Nikoleris <[email protected]>
Gerrit-MessageType: newpatchset
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev