Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/18551
Change subject: cpu: Get rid of the getIsaPtr accessor function.
......................................................................
cpu: Get rid of the getIsaPtr accessor function.
The only place it was used (to get the SVE vector length in ARM) has
been factored out, and so it's no longer necessary. If it becomes
necessary again in the future, a base class should be set up so that
the ThreadContext interface can return that and not be specialized (at
least in that way) towards a particular ISA.
Change-Id: Ie8d83f7b3243dfcb938d2ff7907b61566f5ee81a
---
M src/cpu/checker/thread_context.hh
M src/cpu/o3/thread_context.hh
M src/cpu/simple_thread.hh
M src/cpu/thread_context.hh
4 files changed, 0 insertions(+), 13 deletions(-)
diff --git a/src/cpu/checker/thread_context.hh
b/src/cpu/checker/thread_context.hh
index ed8add6..3db6ada 100644
--- a/src/cpu/checker/thread_context.hh
+++ b/src/cpu/checker/thread_context.hh
@@ -124,8 +124,6 @@
return checkerCPU;
}
- TheISA::ISA *getIsaPtr() override { return actualTC->getIsaPtr(); }
-
TheISA::Decoder *
getDecoderPtr() override
{
diff --git a/src/cpu/o3/thread_context.hh b/src/cpu/o3/thread_context.hh
index e5f0187..046535a 100644
--- a/src/cpu/o3/thread_context.hh
+++ b/src/cpu/o3/thread_context.hh
@@ -86,12 +86,6 @@
CheckerCPU *getCheckerCpuPtr() override { return NULL; }
- TheISA::ISA *
- getIsaPtr() override
- {
- return cpu->isa[thread->threadId()];
- }
-
TheISA::Decoder *
getDecoderPtr() override
{
diff --git a/src/cpu/simple_thread.hh b/src/cpu/simple_thread.hh
index 733047f..7ec1a97 100644
--- a/src/cpu/simple_thread.hh
+++ b/src/cpu/simple_thread.hh
@@ -200,8 +200,6 @@
CheckerCPU *getCheckerCpuPtr() override { return NULL; }
- TheISA::ISA *getIsaPtr() override { return isa; }
-
TheISA::Decoder *getDecoderPtr() override { return &decoder; }
System *getSystemPtr() override { return system; }
diff --git a/src/cpu/thread_context.hh b/src/cpu/thread_context.hh
index bdf5a00..034d620 100644
--- a/src/cpu/thread_context.hh
+++ b/src/cpu/thread_context.hh
@@ -57,7 +57,6 @@
// DTB pointers.
namespace TheISA
{
- class ISA;
class Decoder;
}
class BaseCPU;
@@ -142,8 +141,6 @@
virtual CheckerCPU *getCheckerCpuPtr() = 0;
- virtual TheISA::ISA *getIsaPtr() = 0;
-
virtual TheISA::Decoder *getDecoderPtr() = 0;
virtual System *getSystemPtr() = 0;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18551
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: Ie8d83f7b3243dfcb938d2ff7907b61566f5ee81a
Gerrit-Change-Number: 18551
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
