Tiago Mück has submitted this change and it was merged. (
https://gem5-review.googlesource.com/c/public/gem5/+/18788 )
Change subject: base: AddrRange does not merge single interleaved ranges
......................................................................
base: AddrRange does not merge single interleaved ranges
AddrRange does not attempt to merge interleaved address ranges if it
has only one of the ranges.
This is needed to allow XBars to accept request targeting only one
part of a interleaved address range. A use case for this would be
modeling distributed LLCs in which a XBar is used solely to
encapsulate the snoop filter of a single LLC slice.
Change-Id: If71c9cf1444ee11916611afb51eab3a4f1d93985
Signed-off-by: Tiago Muck <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/18788
Reviewed-by: Nikos Nikoleris <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/base/addr_range.hh
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Nikos Nikoleris: Looks good to me, approved
Jason Lowe-Power: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/base/addr_range.hh b/src/base/addr_range.hh
index 1d2dc73..cda6ccf 100644
--- a/src/base/addr_range.hh
+++ b/src/base/addr_range.hh
@@ -213,6 +213,11 @@
_start = ranges.front()._start;
_end = ranges.front()._end;
masks = ranges.front().masks;
+ intlvMatch = ranges.front().intlvMatch;
+ }
+ // either merge if got all ranges or keep this equal to the single
+ // interleaved range
+ if (ranges.size() > 1) {
if (ranges.size() != (ULL(1) << masks.size()))
fatal("Got %d ranges spanning %d interleaving bits\n",
@@ -231,6 +236,7 @@
++match;
}
masks.clear();
+ intlvMatch = 0;
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/18788
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: If71c9cf1444ee11916611afb51eab3a4f1d93985
Gerrit-Change-Number: 18788
Gerrit-PatchSet: 5
Gerrit-Owner: Tiago Mück <[email protected]>
Gerrit-Assignee: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Matthew Poremba <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: Tiago Mück <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-CC: Andreas Sandberg <[email protected]>
Gerrit-CC: Anthony Gutierrez <[email protected]>
Gerrit-CC: Brandon Potter <[email protected]>
Gerrit-CC: Daniel Carvalho <[email protected]>
Gerrit-CC: Michael LeBeane <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
