Giacomo Travaglini has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/23525 )
Change subject: arch-arm: Always initialize SVE memData
......................................................................
arch-arm: Always initialize SVE memData
Some compilers will produce a warning when using an uninitialized
memData.
JIRA: https://gem5.atlassian.net/browse/GEM5-196
Change-Id: I19e197b15729a03da546a0188917a9b3e7bf31b7
Signed-off-by: Giacomo Travaglini <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/23525
Reviewed-by: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/arch/arm/isa/templates/sve_mem.isa
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved
Giacomo Travaglini: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/isa/templates/sve_mem.isa
b/src/arch/arm/isa/templates/sve_mem.isa
index 933a784..346f47c 100644
--- a/src/arch/arm/isa/templates/sve_mem.isa
+++ b/src/arch/arm/isa/templates/sve_mem.isa
@@ -314,7 +314,7 @@
%(op_rd)s;
%(ea_code)s;
- MemElemType memData;
+ MemElemType memData = 0;
if (fault == NoFault) {
fault = readMemAtomicLE(xc, traceData, EA, memData,
@@ -344,7 +344,7 @@
%(ea_code)s;
- MemElemType memData;
+ MemElemType memData = 0;
if (fault == NoFault) {
fault = initiateMemRead(xc, traceData, EA, memData,
@@ -368,7 +368,7 @@
%(op_decl)s;
%(op_rd)s;
- MemElemType memData;
+ MemElemType memData = 0;
getMemLE(pkt, memData, traceData);
if (fault == NoFault) {
@@ -597,7 +597,7 @@
%(op_rd)s;
%(ea_code)s;
- MemElemType memData;
+ MemElemType memData = 0;
int index = elemIndex;
if (%(pred_check_code)s) {
@@ -663,7 +663,7 @@
%(op_rd)s;
%(ea_code)s;
- MemElemType memData;
+ MemElemType memData = 0;
%(memacc_code)s;
int index = elemIndex;
@@ -693,7 +693,7 @@
%(op_rd)s;
%(ea_code)s;
- MemElemType memData;
+ MemElemType memData = 0;
%(memacc_code)s;
int index = elemIndex;
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/23525
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I19e197b15729a03da546a0188917a9b3e7bf31b7
Gerrit-Change-Number: 23525
Gerrit-PatchSet: 2
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Ciro Santilli <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Nikos Nikoleris <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/gem5-dev
