Bobby R. Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/23984 )
Change subject: tests,base: Added GTest for base/socket.cc
......................................................................
tests,base: Added GTest for base/socket.cc
It should be noted that some features of this class have not been fully
tested due to interaction with system-calls.
Change-Id: I8315188327e022ac4c98aa9ce4bd38243266ab17
---
M src/base/SConscript
A src/base/socket.test.cc
2 files changed, 138 insertions(+), 0 deletions(-)
diff --git a/src/base/SConscript b/src/base/SConscript
index 818428e..3bd4dbb 100644
--- a/src/base/SConscript
+++ b/src/base/SConscript
@@ -70,6 +70,7 @@
if env['TARGET_ISA'] != 'null':
Source('remote_gdb.cc')
Source('socket.cc')
+GTest('socket.test', 'socket.test.cc', 'socket.cc')
Source('statistics.cc')
Source('str.cc')
GTest('str.test', 'str.test.cc', 'str.cc')
diff --git a/src/base/socket.test.cc b/src/base/socket.test.cc
new file mode 100644
index 0000000..f535b0c
--- /dev/null
+++ b/src/base/socket.test.cc
@@ -0,0 +1,137 @@
+/*
+ * Copyright (c) 2020 The Regents of the University of California
+ * All rights reserved
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met: redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer;
+ * redistributions in binary form must reproduce the above copyright
+ * notice, this list of conditions and the following disclaimer in the
+ * documentation and/or other materials provided with the distribution;
+ * neither the name of the copyright holders nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ *
+ * Authors: Bobby R. Bruce
+ */
+
+#include <gtest/gtest.h>
+
+#include "base/socket.hh"
+
+#define TEST_PORT_1 7893
+#define TEST_PORT_2 7894
+
+/*
+ * This mock Listen Socket is used to ensure the static variables are reset
+ * back to false upon deconstruction (i.e., at the end of a test).
+ */
+class MockListenSocket : public ListenSocket {
+ public:
+ ~MockListenSocket()
+ {
+ listeningDisabled = false;
+ anyListening = false;
+ bindToLoopback = false;
+ }
+};
+
+TEST(SocketTest, DefaultBehavior)
+{
+ /*
+ * Tests the default behavior where listenSocket is constructed, and is
+ * not listening to a port.
+ */
+ MockListenSocket listen_socket;
+ EXPECT_EQ(-1, listen_socket.getfd());
+ EXPECT_FALSE(listen_socket.islistening());
+ EXPECT_FALSE(listen_socket.allDisabled());
+}
+
+TEST(SocketTest, DisableAll)
+{
+ MockListenSocket listen_socket;
+ listen_socket.disableAll();
+ EXPECT_EQ(-1, listen_socket.getfd());
+ EXPECT_FALSE(listen_socket.islistening());
+ EXPECT_TRUE(listen_socket.allDisabled());
+}
+
+TEST(SocketTest, ListenToPort)
+{
+ MockListenSocket listen_socket;
+ EXPECT_TRUE(listen_socket.listen(TEST_PORT_1));
+ EXPECT_NE(-1, listen_socket.getfd());
+ EXPECT_TRUE(listen_socket.islistening());
+ EXPECT_FALSE(listen_socket.allDisabled());
+}
+
+TEST(SocketTest, ListenToPortReuseFalse)
+{
+ MockListenSocket listen_socket;
+ /*
+ * The ListenSocket object should have the same state regardless as to
+ * whether reuse is true or false (it is true by default).
+ */
+ EXPECT_TRUE(listen_socket.listen(TEST_PORT_1, false));
+ EXPECT_NE(-1, listen_socket.getfd());
+ EXPECT_TRUE(listen_socket.islistening());
+ EXPECT_FALSE(listen_socket.allDisabled());
+}
+
+TEST(SocketTest, RelistenWithSameInstance)
+{
+ MockListenSocket listen_socket;
+ EXPECT_TRUE(listen_socket.listen(TEST_PORT_1));
+
+ /*
+ * You cannot listen to another port if you are already listening to
one.
+ */
+ testing::internal::CaptureStderr();
+ EXPECT_ANY_THROW(listen_socket.listen(TEST_PORT_1));
+ EXPECT_EQ("panic: Socket already listening!\n",
+ testing::internal::GetCapturedStderr());
+}
+
+TEST(SocketTest, RelistenWithDifferentInstanceOnDifferentPort)
+{
+ MockListenSocket listen_socket;
+ EXPECT_TRUE(listen_socket.listen(TEST_PORT_1));
+
+ /*
+ * You can listen to another port with a different instance.
+ */
+ MockListenSocket listen_socket_2;
+ EXPECT_TRUE(listen_socket_2.listen(TEST_PORT_2));
+}
+
+TEST(SocketTest, RelistenWithDifferentInstanceOnSamePort)
+{
+ MockListenSocket listen_socket;
+ EXPECT_TRUE(listen_socket.listen(TEST_PORT_1));
+
+ /*
+ * You cannot listen to a port that's already being listened to.
+ */
+ MockListenSocket listen_socket_2;
+ EXPECT_FALSE(listen_socket_2.listen(TEST_PORT_1));
+}
+
+TEST(SocketTest, Accept)
+{
+ MockListenSocket listen_socket;
+ EXPECT_EQ(-1, listen_socket.accept());
+}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/23984
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: master
Gerrit-Change-Id: I8315188327e022ac4c98aa9ce4bd38243266ab17
Gerrit-Change-Number: 23984
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list
gem5-dev@gem5.org
http://m5sim.org/mailman/listinfo/gem5-dev
