Hi Giacomo, Thanks for letting us know. I've gone ahead and hit maintainer +1 on them so we can get kokoro's results ASAP. Can you find someone to review them so we can merge them today and release this afternoon (they look fine to me, but I have never looked at this code before ;)).
Thanks! Jason On Thu, May 28, 2020 at 7:56 AM Giacomo Travaglini < giacomo.travagl...@arm.com> wrote: > Hi Jason, > > > > As you can see from the ticket below: > > > > https://gem5.atlassian.net/browse/GEM5-611 > > > > It won’t be possible otherwise to run gem5-ARM in KVM mode with the in > source bootloader. > > It is not a compiler fix. Considering the are several people using KVM, I > consider this critical and would personally > > vote to merge them in the gem5-20 branch. > > > > Giacomo > > > > *From:* Jason Lowe-Power <power...@gmail.com> > *Sent:* 28 May 2020 15:49 > *To:* gem5 Developer List <gem5-dev@gem5.org>; Giacomo Travaglini < > giacomo.travagl...@arm.com> > *Cc:* Bobby Bruce <bbr...@ucdavis.edu> > *Subject:* New ARM patches on staging branch > > > > Hey Giacomo, > > > > I noticed you just pushed two change to the staging branch: > > https://gem5-review.googlesource.com/c/public/gem5/+/29613 > > https://gem5-review.googlesource.com/c/public/gem5/+/29612 > > > > We were going to merge the staging into develop and release this morning > (i.e., it a couple of hours). Are these patches *required* for gem5-20, or > can they go into develop instead? > > > > Said another way, in the past few days, we've only been pushing compiler > fixes to the staging branch. Are these compiler fixes, or other bugs? > > > > I'd *really* like to get this release out ASAP. Could you describe the > severity of the problem that these fixes pertain to? > > > > Thanks, > > Jason > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. > _______________________________________________ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
