Hello Tony Gutierrez, Alexandru Duțu,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29951
to review the following change.
Change subject: arch-gcn3: ds_read_u8 and ds_read_u16 fix
......................................................................
arch-gcn3: ds_read_u8 and ds_read_u16 fix
This changeset zero extends the destination register
for ds_read_u8 and ds_read_u16 instructions.
Change-Id: I193adadd68adf2572b59743b1504f18ad225f506
---
M src/arch/gcn3/insts/instructions.cc
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/arch/gcn3/insts/instructions.cc
b/src/arch/gcn3/insts/instructions.cc
index 8b72e0d..6e5ff42 100644
--- a/src/arch/gcn3/insts/instructions.cc
+++ b/src/arch/gcn3/insts/instructions.cc
@@ -32016,11 +32016,11 @@
void
Inst_DS__DS_READ_U8::completeAcc(GPUDynInstPtr gpuDynInst)
{
- VecOperandU8 vdst(gpuDynInst, extData.VDST);
+ VecOperandU32 vdst(gpuDynInst, extData.VDST);
for (int lane = 0; lane < NumVecElemPerVecReg; ++lane) {
if (gpuDynInst->exec_mask[lane]) {
- vdst[lane] = (reinterpret_cast<VecElemU8*>(
+ vdst[lane] = (VecElemU32)(reinterpret_cast<VecElemU8*>(
gpuDynInst->d_data))[lane];
}
}
@@ -32096,11 +32096,11 @@
void
Inst_DS__DS_READ_U16::completeAcc(GPUDynInstPtr gpuDynInst)
{
- VecOperandU16 vdst(gpuDynInst, extData.VDST);
+ VecOperandU32 vdst(gpuDynInst, extData.VDST);
for (int lane = 0; lane < NumVecElemPerVecReg; ++lane) {
if (gpuDynInst->exec_mask[lane]) {
- vdst[lane] = (reinterpret_cast<VecElemU16*>(
+ vdst[lane] = (VecElemU32)(reinterpret_cast<VecElemU16*>(
gpuDynInst->d_data))[lane];
}
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29951
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I193adadd68adf2572b59743b1504f18ad225f506
Gerrit-Change-Number: 29951
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Alexandru Duțu <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
