Hello Tony Gutierrez,
I'd like you to do a code review. Please visit
https://gem5-review.googlesource.com/c/public/gem5/+/29950
to review the following change.
Change subject: arch-gcn3: convert vALU instruction counters from 32 to
64-bit
......................................................................
arch-gcn3: convert vALU instruction counters from 32 to 64-bit
The vALU instruction counters were previously 32 bits, but for some
workloads this value wraps around and triggers an assert failure
because the max vALU operations are reached. To resolve this, this
commit increases the counter size to 64 bits.
Change-Id: I90ed4514669485cfea7ccc37ba9d69665277bccb
---
M src/gpu-compute/shader.hh
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gpu-compute/shader.hh b/src/gpu-compute/shader.hh
index 238f6e0..3e2e569 100644
--- a/src/gpu-compute/shader.hh
+++ b/src/gpu-compute/shader.hh
@@ -258,8 +258,8 @@
Stats::Vector vectorInstDstOperand;
void regStats();
- int max_valu_insts;
- int total_valu_insts;
+ int64_t max_valu_insts;
+ int64_t total_valu_insts;
Shader(const Params *p);
~Shader();
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/29950
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I90ed4514669485cfea7ccc37ba9d69665277bccb
Gerrit-Change-Number: 29950
Gerrit-PatchSet: 1
Gerrit-Owner: Anthony Gutierrez <[email protected]>
Gerrit-Reviewer: Tony Gutierrez <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s