Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32920 )
Change subject: arch: Remove the "inline" keyword in ThreadInfo.
......................................................................
arch: Remove the "inline" keyword in ThreadInfo.
Methods which are defined inline are already implicitly inline, making
that keyword redundant. It's also inconsistently used.
Change-Id: If6ec3e94d126ae52d9c2f0d3e8ca27f1ac600650
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32920
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Gabe Black <gabebl...@google.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/generic/linux/threadinfo.hh
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved
Gabe Black: Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/generic/linux/threadinfo.hh
b/src/arch/generic/linux/threadinfo.hh
index 73c8173..7bbf2df 100644
--- a/src/arch/generic/linux/threadinfo.hh
+++ b/src/arch/generic/linux/threadinfo.hh
@@ -71,7 +71,7 @@
~ThreadInfo()
{}
- inline Addr
+ Addr
curThreadInfo()
{
if (!TheISA::CurThreadInfoImplemented)
@@ -89,7 +89,7 @@
return sp & ~ULL(0x3fff);
}
- inline Addr
+ Addr
curTaskInfo(Addr thread_info = 0)
{
// Note that in Linux 4.10 the thread_info struct will no longer
have a
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32920
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: If6ec3e94d126ae52d9c2f0d3e8ca27f1ac600650
Gerrit-Change-Number: 32920
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Bobby R. Bruce <bbr...@ucdavis.edu>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
