Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/32922 )
Change subject: arch: Eliminate an unused pair of constants from
isa_traits.hh.
......................................................................
arch: Eliminate an unused pair of constants from isa_traits.hh.
The one questionable use of CurThreadInfoImplemented (always false) and
CurThreadInfoReg (always -1) has been eliminated, making these constants
unnecessary.
Change-Id: Ibfe4f7be7ce5aaf9c5e896146e1b05b3ac752305
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/32922
Reviewed-by: Andreas Sandberg <andreas.sandb...@arm.com>
Maintainer: Andreas Sandberg <andreas.sandb...@arm.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/arch/arm/isa_traits.hh
M src/arch/mips/isa_traits.hh
M src/arch/power/isa_traits.hh
M src/arch/riscv/isa_traits.hh
M src/arch/sparc/isa_traits.hh
M src/arch/x86/isa_traits.hh
6 files changed, 0 insertions(+), 18 deletions(-)
Approvals:
Andreas Sandberg: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/arch/arm/isa_traits.hh b/src/arch/arm/isa_traits.hh
index c9b6eb9..0ce38bc 100644
--- a/src/arch/arm/isa_traits.hh
+++ b/src/arch/arm/isa_traits.hh
@@ -95,9 +95,6 @@
// Memory accesses cannot be unaligned
const bool HasUnalignedMemAcc = true;
- const bool CurThreadInfoImplemented = false;
- const int CurThreadInfoReg = -1;
-
enum InterruptTypes
{
INT_RST,
diff --git a/src/arch/mips/isa_traits.hh b/src/arch/mips/isa_traits.hh
index 5d20f7c..9b44d86 100644
--- a/src/arch/mips/isa_traits.hh
+++ b/src/arch/mips/isa_traits.hh
@@ -138,9 +138,6 @@
const bool HasUnalignedMemAcc = true;
-const bool CurThreadInfoImplemented = false;
-const int CurThreadInfoReg = -1;
-
} // namespace MipsISA
#endif // __ARCH_MIPS_ISA_TRAITS_HH__
diff --git a/src/arch/power/isa_traits.hh b/src/arch/power/isa_traits.hh
index 25499ff..89bfa6b 100644
--- a/src/arch/power/isa_traits.hh
+++ b/src/arch/power/isa_traits.hh
@@ -57,9 +57,6 @@
// Memory accesses can be unaligned
const bool HasUnalignedMemAcc = true;
-const bool CurThreadInfoImplemented = false;
-const int CurThreadInfoReg = -1;
-
} // namespace PowerISA
#endif // __ARCH_POWER_ISA_TRAITS_HH__
diff --git a/src/arch/riscv/isa_traits.hh b/src/arch/riscv/isa_traits.hh
index 18cf485..8ba2e0c 100644
--- a/src/arch/riscv/isa_traits.hh
+++ b/src/arch/riscv/isa_traits.hh
@@ -57,9 +57,6 @@
// Memory accesses can be unaligned (at least for double-word memory
accesses)
const bool HasUnalignedMemAcc = true;
-const bool CurThreadInfoImplemented = false;
-const int CurThreadInfoReg = -1;
-
}
#endif //__ARCH_RISCV_ISA_TRAITS_HH__
diff --git a/src/arch/sparc/isa_traits.hh b/src/arch/sparc/isa_traits.hh
index 3cd6216..7989107 100644
--- a/src/arch/sparc/isa_traits.hh
+++ b/src/arch/sparc/isa_traits.hh
@@ -47,9 +47,6 @@
// Memory accesses cannot be unaligned
const bool HasUnalignedMemAcc = false;
-const bool CurThreadInfoImplemented = false;
-const int CurThreadInfoReg = -1;
-
}
#endif // __ARCH_SPARC_ISA_TRAITS_HH__
diff --git a/src/arch/x86/isa_traits.hh b/src/arch/x86/isa_traits.hh
index 7f55145..98a2dc8 100644
--- a/src/arch/x86/isa_traits.hh
+++ b/src/arch/x86/isa_traits.hh
@@ -52,9 +52,6 @@
// Memory accesses can be unaligned
const bool HasUnalignedMemAcc = true;
-
- const bool CurThreadInfoImplemented = false;
- const int CurThreadInfoReg = -1;
}
#endif // __ARCH_X86_ISATRAITS_HH__
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/32922
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibfe4f7be7ce5aaf9c5e896146e1b05b3ac752305
Gerrit-Change-Number: 32922
Gerrit-PatchSet: 2
Gerrit-Owner: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Andreas Sandberg <andreas.sandb...@arm.com>
Gerrit-Reviewer: Gabe Black <gabebl...@google.com>
Gerrit-Reviewer: Nikos Nikoleris <nikos.nikole...@arm.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
