Tiago Mück has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/31421 )
Change subject: mem-ruby: detailed transaction latency profiling
......................................................................
mem-ruby: detailed transaction latency profiling
Add incomingTransactionStart/End and outgoingTransactionStart/End
functions that can be called from the protocol to profile events
that initiate a transaction locally (e.g. an incoming request) and
remotely (e.g. outgoing requests). The generated stats will include
histograms of the latency for completing each type of transaction.
This assumes assumes the protocol uses different trigger events for
initiating incoming and outgoing transactions.
Change-Id: Ib528641b9676c68907b5989b6a09bfe91373f9c9
Signed-off-by: Tiago Mück <[email protected]>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/31421
Reviewed-by: Jason Lowe-Power <[email protected]>
Reviewed-by: John Alsop <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/mem/ruby/slicc_interface/AbstractController.hh
M src/mem/slicc/symbols/StateMachine.py
2 files changed, 108 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
John Alsop: Looks good to me, but someone else must approve
kokoro: Regressions pass
diff --git a/src/mem/ruby/slicc_interface/AbstractController.hh
b/src/mem/ruby/slicc_interface/AbstractController.hh
index cbe92c0..28103f9 100644
--- a/src/mem/ruby/slicc_interface/AbstractController.hh
+++ b/src/mem/ruby/slicc_interface/AbstractController.hh
@@ -181,6 +181,84 @@
//! Profiles the delay associated with messages.
void profileMsgDelay(uint32_t virtualNetwork, Cycles delay);
+ // Tracks outstanding transactions for latency profiling
+ struct TransMapPair { unsigned transaction; unsigned state; Tick time;
};
+ std::unordered_map<Addr, TransMapPair> m_inTrans;
+ std::unordered_map<Addr, TransMapPair> m_outTrans;
+
+ // Initialized by the SLICC compiler for all combinations of event and
+ // states. Only histograms with samples will appear in the stats
+ std::vector<std::vector<std::vector<Stats::Histogram*>>>
m_inTransLatHist;
+
+ // Initialized by the SLICC compiler for all events.
+ // Only histograms with samples will appear in the stats.
+ std::vector<Stats::Histogram*> m_outTransLatHist;
+
+ /**
+ * Profiles an event that initiates a protocol transactions for a
specific
+ * line (e.g. events triggered by incoming request messages).
+ * A histogram with the latency of the transactions is generated for
+ * all combinations of trigger event, initial state, and final state.
+ *
+ * @param addr address of the line
+ * @param type event that started the transaction
+ * @param initialState state of the line before the transaction
+ */
+ template<typename EventType, typename StateType>
+ void incomingTransactionStart(Addr addr,
+ EventType type, StateType initialState)
+ {
+ assert(m_inTrans.find(addr) == m_inTrans.end());
+ m_inTrans[addr] = {type, initialState, curTick()};
+ }
+
+ /**
+ * Profiles an event that ends a transaction.
+ *
+ * @param addr address of the line with a outstanding transaction
+ * @param finalState state of the line after the transaction
+ */
+ template<typename StateType>
+ void incomingTransactionEnd(Addr addr, StateType finalState)
+ {
+ auto iter = m_inTrans.find(addr);
+ assert(iter != m_inTrans.end());
+ m_inTransLatHist[iter->second.transaction]
+ [iter->second.state]
+ [(unsigned)finalState]->sample(
+ ticksToCycles(curTick() - iter->second.time));
+ m_inTrans.erase(iter);
+ }
+
+ /**
+ * Profiles an event that initiates a transaction in a peer controller
+ * (e.g. an event that sends a request message)
+ *
+ * @param addr address of the line
+ * @param type event that started the transaction
+ */
+ template<typename EventType>
+ void outgoingTransactionStart(Addr addr, EventType type)
+ {
+ assert(m_outTrans.find(addr) == m_outTrans.end());
+ m_outTrans[addr] = {type, 0, curTick()};
+ }
+
+ /**
+ * Profiles the end of an outgoing transaction.
+ * (e.g. receiving the response for a requests)
+ *
+ * @param addr address of the line with an outstanding transaction
+ */
+ void outgoingTransactionEnd(Addr addr)
+ {
+ auto iter = m_outTrans.find(addr);
+ assert(iter != m_outTrans.end());
+ m_outTransLatHist[iter->second.transaction]->sample(
+ ticksToCycles(curTick() - iter->second.time));
+ m_outTrans.erase(iter);
+ }
+
void stallBuffer(MessageBuffer* buf, Addr addr);
void wakeUpBuffers(Addr addr);
void wakeUpAllBuffers(Addr addr);
diff --git a/src/mem/slicc/symbols/StateMachine.py
b/src/mem/slicc/symbols/StateMachine.py
index c019e1b..f4b4dfa 100644
--- a/src/mem/slicc/symbols/StateMachine.py
+++ b/src/mem/slicc/symbols/StateMachine.py
@@ -854,6 +854,36 @@
}
}
}
+ for (${ident}_Event event = ${ident}_Event_FIRST;
+ event < ${ident}_Event_NUM; ++event) {
+ Stats::Histogram* t = new Stats::Histogram;
+ m_outTransLatHist.push_back(t);
+ t->init(5);
+ t->name(name() + ".outTransLatHist." +
+ ${ident}_Event_to_string(event));
+ t->flags(Stats::pdf | Stats::total |
+ Stats::oneline | Stats::nozero);
+ }
+ for (${ident}_Event event = ${ident}_Event_FIRST;
+ event < ${ident}_Event_NUM; ++event) {
+ m_inTransLatHist.emplace_back();
+ for (${ident}_State initial_state = ${ident}_State_FIRST;
+ initial_state < ${ident}_State_NUM; ++initial_state) {
+ m_inTransLatHist.back().emplace_back();
+ for (${ident}_State final_state = ${ident}_State_FIRST;
+ final_state < ${ident}_State_NUM; ++final_state) {
+ Stats::Histogram* t = new Stats::Histogram;
+ m_inTransLatHist.back().back().push_back(t);
+ t->init(5);
+ t->name(name() + ".inTransLatHist." +
+ ${ident}_Event_to_string(event) + "." +
+ ${ident}_State_to_string(initial_state) + "." +
+ ${ident}_State_to_string(final_state));
+ t->flags(Stats::pdf | Stats::total |
+ Stats::oneline | Stats::nozero);
+ }
+ }
+ }
}
void
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/31421
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ib528641b9676c68907b5989b6a09bfe91373f9c9
Gerrit-Change-Number: 31421
Gerrit-PatchSet: 5
Gerrit-Owner: Tiago Mück <[email protected]>
Gerrit-Reviewer: Bradford Beckmann <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: John Alsop <[email protected]>
Gerrit-Reviewer: Tiago Mück <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
