Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/42002 )
Change subject: sim: Don't needlessly recreate ISA types in InstRecord.
......................................................................
sim: Don't needlessly recreate ISA types in InstRecord.
The ISAs already define fully realized types. We don't need to
separately track what parameters they used and then feed them into the
same templates again elsewhere.
Change-Id: Iac18bb9374ff684259c6aa00036eac4d1026dcfc
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/42002
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/sim/insttracer.hh
1 file changed, 6 insertions(+), 9 deletions(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/sim/insttracer.hh b/src/sim/insttracer.hh
index cf16790..079e803 100644
--- a/src/sim/insttracer.hh
+++ b/src/sim/insttracer.hh
@@ -95,9 +95,8 @@
{
uint64_t as_int;
double as_double;
- ::VecRegContainer<TheISA::VecRegSizeBytes>* as_vec;
- ::VecPredRegContainer<TheISA::VecPredRegSizeBits,
- TheISA::VecPredRegHasPackedRepr>* as_pred;
+ TheISA::VecRegContainer* as_vec;
+ TheISA::VecPredRegContainer* as_pred;
} data;
/** @defgroup fetch_seq
@@ -204,18 +203,16 @@
void setData(double d) { data.as_double = d; data_status = DataDouble;
}
void
- setData(::VecRegContainer<TheISA::VecRegSizeBytes>& d)
+ setData(TheISA::VecRegContainer& d)
{
- data.as_vec = new ::VecRegContainer<TheISA::VecRegSizeBytes>(d);
+ data.as_vec = new TheISA::VecRegContainer(d);
data_status = DataVec;
}
void
- setData(::VecPredRegContainer<TheISA::VecPredRegSizeBits,
- TheISA::VecPredRegHasPackedRepr>& d)
+ setData(TheISA::VecPredRegContainer& d)
{
- data.as_pred = new ::VecPredRegContainer<
- TheISA::VecPredRegSizeBits,
TheISA::VecPredRegHasPackedRepr>(d);
+ data.as_pred = new TheISA::VecPredRegContainer(d);
data_status = DataVecPred;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42002
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iac18bb9374ff684259c6aa00036eac4d1026dcfc
Gerrit-Change-Number: 42002
Gerrit-PatchSet: 10
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
