Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/42002 )
Change subject: sim: Don't needlessly recreate ISA types in InstRecord.
......................................................................
sim: Don't needlessly recreate ISA types in InstRecord.
The ISAs already define fully realized types. We don't need to
separately track what parameters they used and then feed them into the
same templates again elsewhere.
Change-Id: Iac18bb9374ff684259c6aa00036eac4d1026dcfc
---
M src/sim/insttracer.hh
1 file changed, 6 insertions(+), 7 deletions(-)
diff --git a/src/sim/insttracer.hh b/src/sim/insttracer.hh
index 636bf76..a2ecad4 100644
--- a/src/sim/insttracer.hh
+++ b/src/sim/insttracer.hh
@@ -94,8 +94,8 @@
union {
uint64_t as_int;
double as_double;
- ::VecRegContainer<TheISA::VecRegSizeBytes>* as_vec;
- ::VecPredRegContainer<TheISA::VecPredRegSizeBits>* as_pred;
+ TheISA::VecRegContainer* as_vec;
+ TheISA::VecPredRegContainer* as_pred;
} data;
/** @defgroup fetch_seq
@@ -201,17 +201,16 @@
void setData(double d) { data.as_double = d; data_status = DataDouble;
}
void
- setData(::VecRegContainer<TheISA::VecRegSizeBytes>& d)
+ setData(TheISA::VecRegContainer& d)
{
- data.as_vec = new ::VecRegContainer<TheISA::VecRegSizeBytes>(d);
+ data.as_vec = new TheISA::VecRegContainer(d);
data_status = DataVec;
}
void
- setData(::VecPredRegContainer<TheISA::VecPredRegSizeBits>& d)
+ setData(TheISA::VecPredRegContainer& d)
{
- data.as_pred =
- new ::VecPredRegContainer<TheISA::VecPredRegSizeBits>(d);
+ data.as_pred = new TheISA::VecPredRegContainer(d);
data_status = DataVecPred;
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/42002
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Iac18bb9374ff684259c6aa00036eac4d1026dcfc
Gerrit-Change-Number: 42002
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
