Giacomo Travaglini has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/45782 )

Change subject: arch-arm: Remove the TLB::flush overload for TLBI IPA
......................................................................

arch-arm: Remove the TLB::flush overload for TLBI IPA

This will be handled by the MMU

Change-Id: I2cc2cae2a742f3c795867b7b85826e482cacc888
Signed-off-by: Giacomo Travaglini <[email protected]>
---
M src/arch/arm/tlb.cc
M src/arch/arm/tlb.hh
M src/arch/arm/tlbi_op.cc
3 files changed, 2 insertions(+), 18 deletions(-)



diff --git a/src/arch/arm/tlb.cc b/src/arch/arm/tlb.cc
index 43edddc..6c8972b 100644
--- a/src/arch/arm/tlb.cc
+++ b/src/arch/arm/tlb.cc
@@ -452,15 +452,6 @@
 }

 void
-TLB::flush(const TLBIIPA &tlbi_op)
-{
-    assert(!isStage2);
-
-    // Note, TLBIIPA::makeStage2 will generare a TLBIMVAA
-    stage2Tlb->flush(tlbi_op.makeStage2());
-}
-
-void
 TLB::drainResume()
 {
     // We might have unserialized something or switched CPUs, so make
diff --git a/src/arch/arm/tlb.hh b/src/arch/arm/tlb.hh
index abe223a..c7144a4 100644
--- a/src/arch/arm/tlb.hh
+++ b/src/arch/arm/tlb.hh
@@ -66,7 +66,6 @@
 class TLBIMVA;
 class TLBIASID;
 class TLBIMVAA;
-class TLBIIPA;

 class TlbTestInterface
 {
@@ -294,12 +293,6 @@
      */
     void flush(const TLBIMVAA &tlbi_op);

-    /**
-     * Invalidate all entries in the stage 2 TLB that match the given ipa
-     * and the current VMID
-     */
-    void flush(const TLBIIPA &tlbi_op);
-
     Fault trickBoxCheck(const RequestPtr &req, Mode mode,
                         TlbEntry::DomainType domain);

diff --git a/src/arch/arm/tlbi_op.cc b/src/arch/arm/tlbi_op.cc
index 5bcc009..d918454 100644
--- a/src/arch/arm/tlbi_op.cc
+++ b/src/arch/arm/tlbi_op.cc
@@ -182,11 +182,11 @@
 void
 TLBIIPA::operator()(ThreadContext* tc)
 {
-    getMMUPtr(tc)->flush(*this);
+    getMMUPtr(tc)->flushStage2(makeStage2());

     CheckerCPU *checker = tc->getCheckerCpuPtr();
     if (checker) {
-        getMMUPtr(checker)->flush(*this);
+        getMMUPtr(checker)->flushStage2(makeStage2());
     }
 }


--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/45782
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I2cc2cae2a742f3c795867b7b85826e482cacc888
Gerrit-Change-Number: 45782
Gerrit-PatchSet: 1
Gerrit-Owner: Giacomo Travaglini <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to