Bobby R. Bruce has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/49065 )
Change subject: tests: Fix ExcludeInterleavingRanges test for .fast comp
......................................................................
tests: Fix ExcludeInterleavingRanges test for .fast comp
Change-Id: Ie3ebfc0caa52f11649f479066022734ac82e6d1b
---
M src/base/addr_range.test.cc
1 file changed, 10 insertions(+), 0 deletions(-)
diff --git a/src/base/addr_range.test.cc b/src/base/addr_range.test.cc
index 42f74a1..bcd5654 100644
--- a/src/base/addr_range.test.cc
+++ b/src/base/addr_range.test.cc
@@ -1423,5 +1423,15 @@
AddrRange r(0x100, 0x200, {1}, 0);
EXPECT_TRUE(r.interleaved());
+
+ /* An `assert(!interleaved());` exists at the top of the `exclude(...)`
+ * method. This means EXPECT_DEATH will only function when DEBUG is
enabled
+ * (as when compiled to `.opt`). When not enabled (as when compiled to
+ * `.fast`), `r.exclude` fails more catastrophically via a `panic`
which
+ * GTest cannot handle correctly.
+ */
+#ifndef NDEBUG
EXPECT_DEATH(r.exclude(exclude_ranges), "");
+#endif
+
}
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49065
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie3ebfc0caa52f11649f479066022734ac82e6d1b
Gerrit-Change-Number: 49065
Gerrit-PatchSet: 1
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
