Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49611 )
14 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: configs: Fix SimpleCore for connect_interrupt() case
......................................................................
configs: Fix SimpleCore for connect_interrupt() case
Something needs done if interrupt_requestor or interrupt_responce is not
set. This patch does not set the interrupts on the cores.
Change-Id: I96aefeec83ff72cb93640c11b2ee60e76f5f32fe
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49611
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M components_library/processors/simple_core.py
1 file changed, 5 insertions(+), 3 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/components_library/processors/simple_core.py
b/components_library/processors/simple_core.py
index 0875fad..202343d 100644
--- a/components_library/processors/simple_core.py
+++ b/components_library/processors/simple_core.py
@@ -95,9 +95,11 @@
self.core.createInterruptController()
if get_runtime_isa() == ISA.X86:
- self.core.interrupts[0].pio = interrupt_requestor
- self.core.interrupts[0].int_requestor = interrupt_responce
- self.core.interrupts[0].int_responder = interrupt_requestor
+ if interrupt_requestor != None:
+ self.core.interrupts[0].pio = interrupt_requestor
+ self.core.interrupts[0].int_responder = interrupt_requestor
+ if interrupt_responce != None:
+ self.core.interrupts[0].int_requestor = interrupt_responce
@overrides(AbstractCore)
def get_mmu(self) -> BaseMMU:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49611
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I96aefeec83ff72cb93640c11b2ee60e76f5f32fe
Gerrit-Change-Number: 49611
Gerrit-PatchSet: 17
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
