Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49610 )
14 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: configs: Fix AbstractGeneratorCore connect_interrupt sig
......................................................................
configs: Fix AbstractGeneratorCore connect_interrupt sig
`interrupt_requestor` and `interrupt_responce` are not manditory, they
should be defaulted to None. Without this errors occur when attempting
to call `connect_interrupt`.
Change-Id: I9401132df681b9a19eede8808a9a68d435cc5bbe
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49610
Tested-by: kokoro <[email protected]>
Reviewed-by: Jason Lowe-Power <[email protected]>
Maintainer: Jason Lowe-Power <[email protected]>
---
M components_library/processors/abstract_generator_core.py
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/components_library/processors/abstract_generator_core.py
b/components_library/processors/abstract_generator_core.py
index 969c94a..226dfa6 100644
--- a/components_library/processors/abstract_generator_core.py
+++ b/components_library/processors/abstract_generator_core.py
@@ -31,6 +31,8 @@
from .cpu_types import CPUTypes
from .abstract_core import AbstractCore
+from typing import Optional
+
class AbstractGeneratorCore(AbstractCore):
"""The abstract generator core
@@ -82,7 +84,9 @@
@overrides(AbstractCore)
def connect_interrupt(
- self, interrupt_requestor: Port, interrupt_responce: Port
+ self,
+ interrupt_requestor: Optional[Port] = None,
+ interrupt_responce: Optional[Port] = None,
) -> None:
"""
Since generator cores are not used in full system mode, no need to
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49610
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I9401132df681b9a19eede8808a9a68d435cc5bbe
Gerrit-Change-Number: 49610
Gerrit-PatchSet: 17
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
