Bobby R. Bruce has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/49929 )
10 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the
submitted one.
Change subject: python: Add `has_dma_ports` check to mesi_two_level
......................................................................
python: Add `has_dma_ports` check to mesi_two_level
Previously the MesiTwoLevelCacheHierarchy assumed the board had dma
ports. This change adds a simple check and skips adding the
DMASequencers if the board does not have any.
Change-Id: I64ee68267d16c9d9a6096ba7fd660f04515b2b3c
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/49929
Tested-by: kokoro <[email protected]>
Reviewed-by: Bobby R. Bruce <[email protected]>
Maintainer: Bobby R. Bruce <[email protected]>
---
M
src/python/gem5/components/cachehierarchies/ruby/mesi_two_level_cache_hierarchy.py
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Bobby R. Bruce: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git
a/src/python/gem5/components/cachehierarchies/ruby/mesi_two_level_cache_hierarchy.py
b/src/python/gem5/components/cachehierarchies/ruby/mesi_two_level_cache_hierarchy.py
index 64eabcd..e5d0353 100644
---
a/src/python/gem5/components/cachehierarchies/ruby/mesi_two_level_cache_hierarchy.py
+++
b/src/python/gem5/components/cachehierarchies/ruby/mesi_two_level_cache_hierarchy.py
@@ -169,13 +169,14 @@
for dir in self._directory_controllers:
dir.ruby_system = self.ruby_system
- dma_ports = board.get_dma_ports()
self._dma_controllers = []
- for i, port in enumerate(dma_ports):
- ctrl = DMAController(self.ruby_system.network, cache_line_size)
- ctrl.dma_sequencer = DMASequencer(version=i, in_ports=port)
- self._dma_controllers.append(ctrl)
- ctrl.ruby_system = self.ruby_system
+ if board.has_dma_ports():
+ dma_ports = board.get_dma_ports()
+ for i, port in enumerate(dma_ports):
+ ctrl = DMAController(self.ruby_system.network,
cache_line_size)
+ ctrl.dma_sequencer = DMASequencer(version=i, in_ports=port)
+ self._dma_controllers.append(ctrl)
+ ctrl.ruby_system = self.ruby_system
self.ruby_system.num_of_sequencers = len(self._l1_controllers) +
len(
self._dma_controllers
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49929
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I64ee68267d16c9d9a6096ba7fd660f04515b2b3c
Gerrit-Change-Number: 49929
Gerrit-PatchSet: 14
Gerrit-Owner: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Bobby R. Bruce <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
