Gabe Black has uploaded this change for review. (
https://gem5-review.googlesource.com/c/public/gem5/+/52031 )
Change subject: arch: Rename PCStateBase to PCStateCommon.
......................................................................
arch: Rename PCStateBase to PCStateCommon.
This class has a lot of common functionality which all PCState classes
use, but in order to make it a true base class which provides the
complete interface for PCState-s throughout gem5, all its methods would
need to become virtual. That doesn't have to be the case today because
we use the literal full ISA specific PC class directly, but we need to
move away from that.
Change-Id: I31309c4f35e897db1bc8318439fae1567a82b35e
---
M src/arch/generic/pcstate.hh
1 file changed, 23 insertions(+), 7 deletions(-)
diff --git a/src/arch/generic/pcstate.hh b/src/arch/generic/pcstate.hh
index 0d73470..791f6f6 100644
--- a/src/arch/generic/pcstate.hh
+++ b/src/arch/generic/pcstate.hh
@@ -54,7 +54,7 @@
{
// The guaranteed interface.
-class PCStateBase : public Serializable
+class PCStateCommon : public Serializable
{
protected:
Addr _pc = 0;
@@ -63,8 +63,8 @@
MicroPC _upc = 0;
MicroPC _nupc = 1;
- PCStateBase() {}
- PCStateBase(Addr val) { set(val); }
+ PCStateCommon() {}
+ PCStateCommon(Addr val) { set(val); }
public:
/**
@@ -117,13 +117,13 @@
void set(Addr val);
bool
- operator == (const PCStateBase &opc) const
+ operator == (const PCStateCommon &opc) const
{
return _pc == opc._pc && _npc == opc._npc;
}
bool
- operator != (const PCStateBase &opc) const
+ operator != (const PCStateCommon &opc) const
{
return !(*this == opc);
}
@@ -156,10 +156,10 @@
// The most basic type of PC.
template <int InstWidth>
-class SimplePCState : public PCStateBase
+class SimplePCState : public PCStateCommon
{
protected:
- typedef PCStateBase Base;
+ typedef PCStateCommon Base;
public:
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52031
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I31309c4f35e897db1bc8318439fae1567a82b35e
Gerrit-Change-Number: 52031
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
