Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/52105 )

Change subject: dev: Get the system's byte order for VirtIO using c++.
......................................................................

dev: Get the system's byte order for VirtIO using c++.

We already have a reference to the system object, so we don't need to
take that as a separate explicit parameter.

Change-Id: Ie8de22541d409f2b2e5544237f472dae6714b437
---
M src/dev/virtio/VirtIO.py
M src/dev/virtio/base.cc
2 files changed, 14 insertions(+), 2 deletions(-)



diff --git a/src/dev/virtio/VirtIO.py b/src/dev/virtio/VirtIO.py
index b0ddb0e..7ecf636 100644
--- a/src/dev/virtio/VirtIO.py
+++ b/src/dev/virtio/VirtIO.py
@@ -51,7 +51,6 @@
     subsystem = Param.UInt8(0x00, "VirtIO subsystem ID")

     system = Param.System(Parent.any, "system object")
-    byte_order = Param.ByteOrder(Parent.byte_order, "Device byte order")

 class VirtIODummyDevice(VirtIODeviceBase):
     type = 'VirtIODummyDevice'
diff --git a/src/dev/virtio/base.cc b/src/dev/virtio/base.cc
index f528cea..afc1e97 100644
--- a/src/dev/virtio/base.cc
+++ b/src/dev/virtio/base.cc
@@ -42,6 +42,7 @@
 #include "params/VirtIODeviceBase.hh"
 #include "params/VirtIODummyDevice.hh"
 #include "sim/serialize.hh"
+#include "sim/system.hh"

 namespace gem5
 {
@@ -340,7 +341,7 @@
size_t config_size, FeatureBits features)
     : SimObject(params),
       guestFeatures(0),
-      byteOrder(params.byte_order),
+      byteOrder(params.system->getGuestByteOrder()),
       deviceId(id), configSize(config_size), deviceFeatures(features),
       _deviceStatus(0), _queueSelect(0)
 {

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52105
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ie8de22541d409f2b2e5544237f472dae6714b437
Gerrit-Change-Number: 52105
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to