Gabe Black has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/52406 )
Change subject: dev-arm: Ensure all fields of GicV2 are initialized.
......................................................................
dev-arm: Ensure all fields of GicV2 are initialized.
The constructor tried to initialize all values, but in particular missed
intGroup, and may have missed other values as well.
Change-Id: Ibcd610e40259e46e3cde9b76c7f9ddc816832dfd
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/52406
Reviewed-by: Giacomo Travaglini <[email protected]>
Maintainer: Giacomo Travaglini <[email protected]>
Tested-by: kokoro <[email protected]>
---
M src/dev/arm/gic_v2.cc
1 file changed, 17 insertions(+), 1 deletion(-)
Approvals:
Giacomo Travaglini: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
diff --git a/src/dev/arm/gic_v2.cc b/src/dev/arm/gic_v2.cc
index bd780ee..bceccf8 100644
--- a/src/dev/arm/gic_v2.cc
+++ b/src/dev/arm/gic_v2.cc
@@ -76,7 +76,7 @@
cpuPioDelay(p.cpu_pio_delay), intLatency(p.int_latency),
enabled(false), haveGem5Extensions(p.gem5_extensions),
itLines(p.it_lines),
- intEnabled {}, pendingInt {}, activeInt {},
+ intEnabled {}, pendingInt {}, activeInt {}, intGroup {},
intPriority {}, intConfig {}, cpuTarget {},
cpuSgiPending {}, cpuSgiActive {},
cpuSgiPendingExt {}, cpuSgiActiveExt {},
--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/52406
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibcd610e40259e46e3cde9b76c7f9ddc816832dfd
Gerrit-Change-Number: 52406
Gerrit-PatchSet: 4
Gerrit-Owner: Gabe Black <[email protected]>
Gerrit-Reviewer: Andreas Sandberg <[email protected]>
Gerrit-Reviewer: Gabe Black <[email protected]>
Gerrit-Reviewer: Giacomo Travaglini <[email protected]>
Gerrit-Reviewer: Jason Lowe-Power <[email protected]>
Gerrit-Reviewer: kokoro <[email protected]>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- [email protected]
To unsubscribe send an email to [email protected]
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s
