Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/56669 )

Change subject: arch-x86: Stop importing X86ISAInst::MicrocodeRom into X86ISA.
......................................................................

arch-x86: Stop importing X86ISAInst::MicrocodeRom into X86ISA.

This is unnecessary and adds complexity.

Change-Id: I44debf09c4c87763ea592074594fac62c623c84a
---
M src/arch/x86/microcode_rom.hh
M src/arch/x86/ucasmlib/arch/x86/rom.py
2 files changed, 12 insertions(+), 2 deletions(-)



diff --git a/src/arch/x86/microcode_rom.hh b/src/arch/x86/microcode_rom.hh
index 1c95154..34115d9 100644
--- a/src/arch/x86/microcode_rom.hh
+++ b/src/arch/x86/microcode_rom.hh
@@ -83,7 +83,6 @@
 namespace X86ISA
 {

-using X86ISAInst::MicrocodeRom;

 } // namespace X86ISA
 } // namespace gem5
diff --git a/src/arch/x86/ucasmlib/arch/x86/rom.py b/src/arch/x86/ucasmlib/arch/x86/rom.py
index d24b9ac..74ddeb6 100644
--- a/src/arch/x86/ucasmlib/arch/x86/rom.py
+++ b/src/arch/x86/ucasmlib/arch/x86/rom.py
@@ -44,5 +44,5 @@
         allocator = "{" + ',\n'.join(elements) + "}"

         return '''
-X86ISA::MicrocodeRom::MicrocodeRom() : genFuncs(%s) {}
+X86ISAInst::MicrocodeRom::MicrocodeRom() : genFuncs(%s) {}
 ''' % allocator

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56669
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I44debf09c4c87763ea592074594fac62c623c84a
Gerrit-Change-Number: 56669
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to