Gabe Black has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/56673 )

Change subject: arch: Don't write out parsetab.py for the ucode assembler.
......................................................................

arch: Don't write out parsetab.py for the ucode assembler.

This file helps make startup of the assembler slightly faster since it
caches part of the parser generation, but if there are multiple
instances of the assembler started at once (by a parallel build for
instance), these clobber each others attempt to write this file. To
avoid that, just don't write out that file.

In the future we could generate that file and actually check it in to
git, although maintaining that file would be annoying if the assembler
changed frequently, and I think the overhead is small compared to other
overheads in the build.

Change-Id: Ibf1a5b5220e2c8594ca4ccf6628f8585cda9cee4
---
M src/arch/ucasmlib/assembler.py
1 file changed, 21 insertions(+), 1 deletion(-)



diff --git a/src/arch/ucasmlib/assembler.py b/src/arch/ucasmlib/assembler.py
index ea98c58..78fff9d 100644
--- a/src/arch/ucasmlib/assembler.py
+++ b/src/arch/ucasmlib/assembler.py
@@ -341,7 +341,7 @@
         # "lexer" property can return something.
         self.lexers = [('dummy', None)]
         self.lexers = [('<string>', lex.lex(object=self))]
-        self.parser = yacc.yacc(module=self)
+        self.parser = yacc.yacc(module=self, write_tables=False)
         self.macro_type = macro_type
         self.macros = {}
         self.macroops = {}

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/56673
To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: Ibf1a5b5220e2c8594ca4ccf6628f8585cda9cee4
Gerrit-Change-Number: 56673
Gerrit-PatchSet: 1
Gerrit-Owner: Gabe Black <gabe.bl...@gmail.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
%(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

Reply via email to