Nicolas Boichat has uploaded this change for review. ( https://gem5-review.googlesource.com/c/public/gem5/+/67233?usp=email )

Change subject: scons: Clone env before modifying it in SharedLib
......................................................................

scons: Clone env before modifying it in SharedLib

Without this, modifications to env propagate to unexpected places.
This mirrors behaviour in Executable (where the code was copied from).

Change-Id: I35bbf2f3cc2786eb50ff751c813853971ab284fe
Signed-off-by: Nicolas Boichat <drink...@google.com>
---
M src/SConscript
1 file changed, 15 insertions(+), 0 deletions(-)



diff --git a/src/SConscript b/src/SConscript
index 51b4bd9..3179849 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -376,6 +376,8 @@
     def declare(self, env):
         objs = self.srcs_to_objs(env, self.sources(env))

+        env = env.Clone()
+
         libs = self.libs(env)
         # Higher priority libraries should be earlier in the list.
         libs.sort(key=lambda l: l.priority, reverse=True)

--
To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/67233?usp=email To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings

Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I35bbf2f3cc2786eb50ff751c813853971ab284fe
Gerrit-Change-Number: 67233
Gerrit-PatchSet: 1
Gerrit-Owner: Nicolas Boichat <drink...@google.com>
Gerrit-MessageType: newchange
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org

Reply via email to