Nicolas Boichat has submitted this change. (
https://gem5-review.googlesource.com/c/public/gem5/+/67233?usp=email )
Change subject: scons: Clone env before modifying it in SharedLib
......................................................................
scons: Clone env before modifying it in SharedLib
Without this, modifications to env propagate to unexpected places.
This mirrors behaviour in Executable (where the code was copied from).
Change-Id: I35bbf2f3cc2786eb50ff751c813853971ab284fe
Signed-off-by: Nicolas Boichat <drink...@google.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/67233
Maintainer: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Jason Lowe-Power <power...@gmail.com>
Reviewed-by: Gabe Black <gabe.bl...@gmail.com>
Tested-by: kokoro <noreply+kok...@google.com>
---
M src/SConscript
1 file changed, 20 insertions(+), 0 deletions(-)
Approvals:
Jason Lowe-Power: Looks good to me, approved; Looks good to me, approved
kokoro: Regressions pass
Gabe Black: Looks good to me, approved
diff --git a/src/SConscript b/src/SConscript
index 51b4bd9..3179849 100644
--- a/src/SConscript
+++ b/src/SConscript
@@ -376,6 +376,8 @@
def declare(self, env):
objs = self.srcs_to_objs(env, self.sources(env))
+ env = env.Clone()
+
libs = self.libs(env)
# Higher priority libraries should be earlier in the list.
libs.sort(key=lambda l: l.priority, reverse=True)
--
To view, visit
https://gem5-review.googlesource.com/c/public/gem5/+/67233?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gem5-review.googlesource.com/settings
Gerrit-Project: public/gem5
Gerrit-Branch: develop
Gerrit-Change-Id: I35bbf2f3cc2786eb50ff751c813853971ab284fe
Gerrit-Change-Number: 67233
Gerrit-PatchSet: 2
Gerrit-Owner: Nicolas Boichat <drink...@google.com>
Gerrit-Reviewer: Gabe Black <gabe.bl...@gmail.com>
Gerrit-Reviewer: Giacomo Travaglini <giacomo.travagl...@arm.com>
Gerrit-Reviewer: Jason Lowe-Power <power...@gmail.com>
Gerrit-Reviewer: Nicolas Boichat <drink...@google.com>
Gerrit-Reviewer: kokoro <noreply+kok...@google.com>
Gerrit-MessageType: merged
_______________________________________________
gem5-dev mailing list -- gem5-dev@gem5.org
To unsubscribe send an email to gem5-dev-le...@gem5.org
