Great patch Brad. A few comments/questions:
1) Why is this necessary immediately after converting the string to lowercase?
for (size_t i=0;i<str.length();i++)
lower[i] = tolower(str[i]);
- if (lower == "true")
+ if (lower == "true" || lower == "True")
return true;
- else if (lower == "false")
+ else if (lower == "false" || lower == "False")
return false;
2) Would it be possible to update MOESI_CMP_directory and
MESI_CMP_directory to utilize these changes as well?
3) In MI_example-homogenous, could you change the option from -u to
-U? -u is already used in rocks, which creates a problem because
rocks and ruby share the same command line.
4) Why did you comment this out? (in cfg.rb)
+ #assert (val.is_a?(Integer) or val == "rand"),
"RubySystem.random_seed takes either an integer value or the string
\"rand\""
5) In cache memory, why do you account for the case where cache_size is zero?
-Derek
On Fri, Sep 11, 2009 at 6:09 PM, Beckmann, Brad <[email protected]> wrote:
> Hi All,
>
>
>
> Attached is a patch I would like to check in that allows Ruby to support a
> very large memory address space and high core count. Currently ruby uses a
> flat array to store the memory state of the system. This works well when
> the simulated system is roughly 4 GB or less, but is not practical for 128
> GB+ systems. The patch provides the Directory Memory a sparse memory data
> structure, which is essentially a hierarchical map. The patch also includes
> various bug fixes including configuration string parsing and debug fixes.
>
>
>
> Let me know what you think. If I don’t hear any complaints within a week,
> I’ll go ahead and check it in.
>
>
>
> Brad
>
>
>
> _______________________________________________
> m5-dev mailing list
> [email protected]
> http://m5sim.org/mailman/listinfo/m5-dev
>
>
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
