Darn...I was hoping -X would work. So by manually creating multiple patches, you mean qnew a few almost empty patches and then cut-and-paste the one patch into those new patch files, right?
It may be just me, but I have a hard time determining in real time when a modification requires a new patch. After the fact, when the code is cleaned up, I can see the separation. However, when I'm first trying something, it is not always clear whether a modification is something I want to keep and deserves a separate patch. Once I was done I used the -X option with qrefresh to separate my internal and public changes to two separate patches, but now realize I should have also split my public changes into multiple patches as well. Brad -----Original Message----- From: [email protected] [mailto:[email protected]] On Behalf Of nathan binkert Sent: Friday, September 18, 2009 11:52 AM To: M5 Developer List Subject: Re: [m5-dev] Large Memory support in Ruby >> - In hindsight, one may see the items in this patch as unrelated, >> but I initially created this patch with the sole goal of adding >> large memory support to Ruby. It turned out I encountered a lot of >> issues throughout the code, and there are more to come. That being >> said, I have no problem using the "-X" option to separate these out >> to multiple changesets when I commit them. > > What I do when that happens is refresh my current patch, pop it, write > a patch that fixes whatever the issue is, refresh it, and then push my > first patch back on. Then everything stays seperated into minimal > logical units which makes history diving a lot nicer. Another thing that you can do if lots of things wind up in the same patch is to manually pull the patch apart into multiple patches. It sounds like a pain, but it's really not that hard to do. Also, I don't think the -X option works when you're using mq because when you convert an applied patch to a changeset (using hg qdel -r), you're not actually doing a commit. Nate _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
