> # HG changeset patch
> # User Brad Beckmann <[email protected]>
> # Date 1261412980 28800
> # Node ID 2b2eb8881591bd418466cabcd2c855d9ea31dd7f
> # Parent a69fcc6caa1ba560ded1c5cf86d0c6f419467f04
> ruby: Cleaned up static members in RubyPort
> Removed static members in RubyPort and removed the ruby request unique id.
> This patch
> currently breaks atomic support and libruby. More changes are needed.
Seems to me that this patch cannot go in.
> diff -r a69fcc6caa1b -r 2b2eb8881591 src/mem/ruby/libruby.cc
> --- a/src/mem/ruby/libruby.cc Mon Dec 21 08:29:40 2009 -0800
> +++ b/src/mem/ruby/libruby.cc Mon Dec 21 08:29:40 2009 -0800
> @@ -123,7 +123,11 @@
>
> RubyPortHandle libruby_get_port(const char* port_name, void
> (*hit_callback)(int64_t access_id))
> {
> - return static_cast<RubyPortHandle>(RubySystem::getPort(port_name,
> hit_callback));
> + //
> + // Fix me: Hit callback is now a non-static member function pointer of
> + // RubyPort and cannot be set to an arbitrary global function
> + //
> + return NULL;//static_cast<RubyPortHandle>(RubySystem::getPort(port_name,
> hit_callback));
> }
What is the plan to fix this?
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev
