Thanks for the comments, Gabe. You're right - these are the updated patches after initial comments.
The regressions all pass, so there are no problems there. What I'll do is wait a week for Kevin to email and if he hasn't by next Friday I'll commit them then. Cheers Tim On Thu, 04 Feb 2010 03:15:47 -0500, Gabe Black <[email protected]> wrote: > The original email and my own vague memories suggest these patches were > sent out once, there was some feedback, and you fixed them up and sent > them out again. Is that right? I looked through them fairly quickly and > didn't see anything that seemed wrong. The majority of the changes are > in O3, I think, so it would be great if Kevin could comment. I'm not > sure if he's still M5ing these days so I wouldn't necessarily wait for > him. Otherwise, it would be fine to commit them as far as I can see, > assuming they still apply cleanly and the regressions pass. > > Gabe > > Timothy M Jones wrote: >> Hi everyone, >> >> I just realised that I didn't ever actually commit these patches. Does >> anyone have any problems with them, or can I go ahead? I know it's ISCA >> rebuttal period, so no rush (it's been a month and a half anyhow, I'm >> sure >> a little longer won't hurt!) >> >> Cheers >> Tim >> >> On Mon, 14 Dec 2009 10:10:39 -0500, Timothy M. Jones >> <[email protected]> wrote: >> >> >>> These are the updated patches that perform timing TLB translation >>> (instead >>> of atomic) in base_dyn_inst.hh and then split O3 memory accesses into >>> two >>> reads or writes when they cross a cache line boundary. All regression >>> tests >>> pass without problems. >>> >>> Changes from last time: >>> * Alterations to TimingSimpleCPU folded into original patch >>> * New const variable added to compile out split code from O3CPU if the >>> ISA does not need it >>> * Templating on ExecContext class to avoid virtual function calls >>> * All calls to read / write for O3CPU now just have NULL for the split >>> packets if the split hasn't occured (instead of using different >>> functions) >>> >>> Any further comments appreciated. >>> >>> Tim >>> >>> >> >> >> > > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev > -- The University of Edinburgh is a charitable body, registered in Scotland, with registration number SC005336. _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
