Hi Nate, As you can see by the Reviewboard emails, I reviewed 3 of your 4 patches. However before I complete my review on your map patches, I want to inline my comments into the diff as you suggested below. I noticed that I could download the diff and manually insert my comments, but I'm pretty sure that is not what you are suggesting.
So how do I insert my reviews? Can I use my browser window or do I need to download a separate tool? Thanks, Brad > -----Original Message----- > From: [email protected] [mailto:[email protected]] On > Behalf Of nathan binkert > Sent: Monday, June 07, 2010 8:50 PM > To: Nilay Vaish; Ruby Reviewers; Nathan Binkert > Subject: Re: [m5-dev] Review Request: ruby: get rid of Vector and use > STL > > >> Ignore the ship it tag above. I was testing what happens if I > check the box provided. Is it a vote in favor of the patch? > Yes. > > One other thing. Can you make your future comments inline in the > patch if they are about specific things? It's not always obvious > otherwise. > > Thanks, > > Nate > _______________________________________________ > m5-dev mailing list > [email protected] > http://m5sim.org/mailman/listinfo/m5-dev _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
