> As you can see by the Reviewboard emails, I reviewed 3 of your 4 patches.  
> However before I complete my review on your map patches, I want to inline my 
> comments into the diff as you suggested below.  I noticed that I could 
> download the diff and manually insert my comments, but I'm pretty sure that 
> is not what you are suggesting.
>
> So how do I insert my reviews?  Can I use my browser window or do I need to 
> download a separate tool?

In the browser, if you click on a line, you can add a comment.  You
might have to click on a line number.  Unfortunately, I've already
committed these, so any brokenness will have to be fixed in another
patch.

  Nate
_______________________________________________
m5-dev mailing list
[email protected]
http://m5sim.org/mailman/listinfo/m5-dev

Reply via email to