> On 2010-06-21 15:53:47, Brad Beckmann wrote: > > Overall, this patch looks good. I just have a couple questions about it:
1. It appears that the stl_helpers class allows us to overload the operator<< for Ruby style printing. That is great. Thanks for maintaining this feature as we move to stl. So have you looked at the print out for Ruby objects such as NetDest? Are the print outs for these functions equivalent before and after your changes? 2. Why does DeterministicDriver use the std namespace? 1. I thought so, but I guess we should double check at some point. 2. Because std::vector is used without the std:: and I nuked the "using namespace std;" that was in a header somewhere. - Nathan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/22/#review46 ----------------------------------------------------------- On 2010-06-02 15:56:35, Nathan Binkert wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/22/ > ----------------------------------------------------------- > > (Updated 2010-06-02 15:56:35) > > > Review request for Ruby Reviewers. > > > Summary > ------- > > ruby: get rid of Vector and use STL > add a couple of helper functions to base for deleteing all pointers in > a container and outputting containers to a stream > > > Diffs > ----- > > src/base/stl_helpers.hh PRE-CREATION > src/cpu/rubytest/CheckTable.hh be2acdfb8bdc > src/cpu/rubytest/CheckTable.cc be2acdfb8bdc > src/cpu/rubytest/RubyTester.hh be2acdfb8bdc > src/cpu/rubytest/RubyTester.cc be2acdfb8bdc > src/mem/gems_common/Map.hh be2acdfb8bdc > src/mem/gems_common/PrioHeap.hh be2acdfb8bdc > src/mem/gems_common/Vector.hh be2acdfb8bdc > src/mem/ruby/buffers/MessageBuffer.hh be2acdfb8bdc > src/mem/ruby/common/DataBlock.hh be2acdfb8bdc > src/mem/ruby/common/Histogram.hh be2acdfb8bdc > src/mem/ruby/common/Histogram.cc be2acdfb8bdc > src/mem/ruby/common/NetDest.hh be2acdfb8bdc > src/mem/ruby/common/NetDest.cc be2acdfb8bdc > src/mem/ruby/common/SubBlock.hh be2acdfb8bdc > src/mem/ruby/common/SubBlock.cc be2acdfb8bdc > src/mem/ruby/eventqueue/RubyEventQueue.hh be2acdfb8bdc > src/mem/ruby/filters/BlockBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/BlockBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/BulkBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/BulkBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/H3BloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/H3BloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/LSB_CountingBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/LSB_CountingBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/MultiBitSelBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/MultiBitSelBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/MultiGrainBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/MultiGrainBloomFilter.cc be2acdfb8bdc > src/mem/ruby/filters/NonCountingBloomFilter.hh be2acdfb8bdc > src/mem/ruby/filters/NonCountingBloomFilter.cc be2acdfb8bdc > src/mem/ruby/network/Network.hh be2acdfb8bdc > src/mem/ruby/network/Network.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/GarnetNetwork_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/InputUnit_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.hh > be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/NetworkLink_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/OutputUnit_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/Router_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/RoutingUnit_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/SWallocator_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.hh be2acdfb8bdc > src/mem/ruby/network/garnet/fixed-pipeline/VCallocator_d.cc be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/GarnetNetwork.cc be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.hh > be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/NetworkLink.cc be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/Router.hh be2acdfb8bdc > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc be2acdfb8bdc > src/mem/ruby/network/simple/PerfectSwitch.hh be2acdfb8bdc > src/mem/ruby/network/simple/PerfectSwitch.cc be2acdfb8bdc > src/mem/ruby/network/simple/SimpleNetwork.hh be2acdfb8bdc > src/mem/ruby/network/simple/SimpleNetwork.cc be2acdfb8bdc > src/mem/ruby/network/simple/Switch.hh be2acdfb8bdc > src/mem/ruby/network/simple/Switch.cc be2acdfb8bdc > src/mem/ruby/network/simple/Throttle.hh be2acdfb8bdc > src/mem/ruby/network/simple/Throttle.cc be2acdfb8bdc > src/mem/ruby/network/simple/Topology.hh be2acdfb8bdc > src/mem/ruby/network/simple/Topology.cc be2acdfb8bdc > src/mem/ruby/profiler/AddressProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/CacheProfiler.hh be2acdfb8bdc > src/mem/ruby/profiler/CacheProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/MemCntrlProfiler.hh be2acdfb8bdc > src/mem/ruby/profiler/MemCntrlProfiler.cc be2acdfb8bdc > src/mem/ruby/profiler/Profiler.hh be2acdfb8bdc > src/mem/ruby/profiler/Profiler.cc be2acdfb8bdc > src/mem/ruby/system/CacheMemory.hh be2acdfb8bdc > src/mem/ruby/system/CacheMemory.cc be2acdfb8bdc > src/mem/ruby/system/MemoryVector.hh be2acdfb8bdc > src/mem/ruby/system/Sequencer.cc be2acdfb8bdc > src/mem/ruby/system/System.hh be2acdfb8bdc > src/mem/ruby/system/System.cc be2acdfb8bdc > src/mem/ruby/system/TimerTable.cc be2acdfb8bdc > src/mem/ruby/tester/DeterministicDriver.hh be2acdfb8bdc > src/mem/ruby/tester/DeterministicDriver.cc be2acdfb8bdc > src/mem/ruby/tester/RaceyDriver.hh be2acdfb8bdc > src/mem/ruby/tester/RaceyDriver.cc be2acdfb8bdc > src/mem/slicc/symbols/StateMachine.py be2acdfb8bdc > > Diff: http://reviews.m5sim.org/r/22/diff > > > Testing > ------- > > All regressions pass > > > Thanks, > > Nathan > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
