> On 2010-07-11 15:25:09, Nathan Binkert wrote: > > src/sim/syscall_emul.cc, line 190 > > <http://reviews.m5sim.org/r/52/diff/1/?file=758#file758line190> > > > > I personally feel that the use of ?: here isn't warranted. It hides > > what this line of code is actually doing. Much better IMHO to do this even > > though it is more verbose: > > int status = 0; > > if (sim_fd > 2) > > status = close(sim_fd);
That's cool. I am happy to change this. - Timothy ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/52/#review85 ----------------------------------------------------------- On 2010-07-09 18:15:33, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/52/ > ----------------------------------------------------------- > > (Updated 2010-07-09 18:15:33) > > > Review request for Default. > > > Summary > ------- > > Syscall: Don't close the simulator's standard file descriptors. > > > Diffs > ----- > > src/sim/syscall_emul.cc 249f174e6f37 > > Diff: http://reviews.m5sim.org/r/52/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
