No problem. Looks good.
On Fri, Jul 16, 2010 at 5:58 PM, Timothy Jones <[email protected]> wrote: > > >> On 2010-07-16 14:09:40, Nathan Binkert wrote: >> > src/sim/syscall_emul.cc, line 192 >> > <http://reviews.m5sim.org/r/52/diff/2/?file=807#file807line192> >> > >> > this should be: >> > status = close(sim_fd); > > Sorry, that was sloppy of me. I've fixed it up now. > > > - Timothy > > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/52/#review91 > ----------------------------------------------------------- > > > On 2010-07-16 17:57:30, Timothy Jones wrote: >> >> ----------------------------------------------------------- >> This is an automatically generated e-mail. To reply, visit: >> http://reviews.m5sim.org/r/52/ >> ----------------------------------------------------------- >> >> (Updated 2010-07-16 17:57:30) >> >> >> Review request for Default. >> >> >> Summary >> ------- >> >> Syscall: Don't close the simulator's standard file descriptors. >> >> >> Diffs >> ----- >> >> src/sim/syscall_emul.cc 249f174e6f37 >> >> Diff: http://reviews.m5sim.org/r/52/diff >> >> >> Testing >> ------- >> >> >> Thanks, >> >> Timothy >> >> > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
