----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/52/#review104 -----------------------------------------------------------
src/sim/syscall_emul.cc <http://reviews.m5sim.org/r/52/#comment246> We might want a more robust way of detecting whether a file descriptor is safe to close. This will catch instances where stdout, stderr and stdin are forwarded to the simulated program, but could there be others? I can't think of any off hand, but we should at least think about it carefully. This shouldn't prevent you from checking this in, though, since some allegedly imperfect protection is better than no protection. - Gabe On 2010-07-16 17:57:30, Timothy Jones wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/52/ > ----------------------------------------------------------- > > (Updated 2010-07-16 17:57:30) > > > Review request for Default. > > > Summary > ------- > > Syscall: Don't close the simulator's standard file descriptors. > > > Diffs > ----- > > src/sim/syscall_emul.cc 249f174e6f37 > > Diff: http://reviews.m5sim.org/r/52/diff > > > Testing > ------- > > > Thanks, > > Timothy > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
