> On 2010-10-24 21:45:51, Steve Reinhardt wrote: > > src/mem/ruby/storebuffer/storebuffer.cc, line 163 > > <http://reviews.m5sim.org/r/277/diff/2/?file=4572#file4572line163> > > > > In these cases (and the ones below) where this is really a fatal error, > > I believe the whole ERROR_OUT/DEBUG_EXPR/ASSERT(0) sequence should be > > replaced by a single call to panic(), which takes the same arguments as > > cprintf(). I think if you're dying you don't want to only print relevant > > info if you had traceflags enabled too.
Let's handle ERROR_OUT calls in a different set of changes. We will be going through Ruby's assert mechanism soon. > On 2010-10-24 21:45:51, Steve Reinhardt wrote: > > src/mem/slicc/ast/FuncCallExprAST.py, line 51 > > <http://reviews.m5sim.org/r/277/diff/2/?file=4578#file4578line51> > > > > What is this code doing? It looks like it's inserting the location, > > but how does this work if the format string isn't changed? Plus it would > > be nice to have a comment here in the SLICC code too. The code inserts the location of the DPRINTF() statement in the .sm file in the statement it self. The second argument in the call to 'code()' function represents the location. This is placed where $0 appears in the first argument of the 'code()' function. 'format' represents the second argument of the original DPRINTF() call. It is left unmodified. str_list is used for concatenating the argument list following the format specifier in a DPRINTF() call. A DPRINTF() call may or may not contain any arguments following the format specifier. Consider the examples DPRINTF(RubySlicc,"Hello!") and DPRINTF(RubySlicc,"%s",address). These two need to be handled differently. Hence the check whether or not the str_list is empty. > On 2010-10-24 21:45:51, Steve Reinhardt wrote: > > src/mem/protocol/MI_example-dir.sm, line 170 > > <http://reviews.m5sim.org/r/277/diff/2/?file=4550#file4550line170> > > > > Can some of these FooBarBazType_to_string() functions, like the one > > here and several more below, be converted to (or hidden behind) operator<<? > > That's not strictly necessary but it would make these calls a lot less > > verbose. I will make these changes and update the diff soon. - Nilay ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/277/#review415 ----------------------------------------------------------- On 2010-10-24 08:59:56, Nilay Vaish wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/277/ > ----------------------------------------------------------- > > (Updated 2010-10-24 08:59:56) > > > Review request for Default and Ruby Reviewers. > > > Summary > ------- > > Ruby currently uses GEMS debug support with the enum character string map to > enable certain debug messages. Meanwhile, M5 has debug print support that > works with scons. Compiling the m5.fast binary, the M5 debug statements are > removed, but the Ruby ones are not unless RUBY_DEBUG is not defined. This > patch moves Ruby to M5's debug print support. > > > Diffs > ----- > > src/cpu/testers/rubytest/CheckTable.cc f166f8bd8818 > src/mem/SConscript f166f8bd8818 > src/mem/protocol/MESI_CMP_directory-L1cache.sm f166f8bd8818 > src/mem/protocol/MESI_CMP_directory-L2cache.sm f166f8bd8818 > src/mem/protocol/MESI_CMP_directory-dir.sm f166f8bd8818 > src/mem/protocol/MI_example-cache.sm f166f8bd8818 > src/mem/protocol/MI_example-dir.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_directory-L1cache.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_directory-L2cache.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_directory-dir.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_directory-perfectDir.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_token-L1cache.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_token-L2cache.sm f166f8bd8818 > src/mem/protocol/MOESI_CMP_token-dir.sm f166f8bd8818 > src/mem/protocol/MOESI_hammer-cache.sm f166f8bd8818 > src/mem/protocol/MOESI_hammer-dir.sm f166f8bd8818 > src/mem/ruby/SConsopts f166f8bd8818 > src/mem/ruby/buffers/MessageBuffer.cc f166f8bd8818 > src/mem/ruby/common/Debug.hh f166f8bd8818 > src/mem/ruby/common/Debug.cc f166f8bd8818 > src/mem/ruby/common/NetDest.hh f166f8bd8818 > src/mem/ruby/network/garnet/fixed-pipeline/NetworkInterface_d.cc > f166f8bd8818 > src/mem/ruby/network/garnet/fixed-pipeline/Switch_d.cc f166f8bd8818 > src/mem/ruby/network/garnet/flexible-pipeline/NetworkInterface.cc > f166f8bd8818 > src/mem/ruby/network/garnet/flexible-pipeline/Router.cc f166f8bd8818 > src/mem/ruby/network/simple/PerfectSwitch.cc f166f8bd8818 > src/mem/ruby/network/simple/Throttle.cc f166f8bd8818 > src/mem/ruby/network/simple/Topology.cc f166f8bd8818 > src/mem/ruby/storebuffer/storebuffer.cc f166f8bd8818 > src/mem/ruby/system/CacheMemory.cc f166f8bd8818 > src/mem/ruby/system/DirectoryMemory.cc f166f8bd8818 > src/mem/ruby/system/SConscript f166f8bd8818 > src/mem/ruby/system/SparseMemory.cc f166f8bd8818 > src/mem/ruby/tester/RaceyPseudoThread.cc f166f8bd8818 > src/mem/slicc/ast/FuncCallExprAST.py f166f8bd8818 > src/mem/slicc/symbols/StateMachine.py f166f8bd8818 > > Diff: http://reviews.m5sim.org/r/277/diff > > > Testing > ------- > > > Thanks, > > Nilay > > _______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
