----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/316/#review489 -----------------------------------------------------------
src/python/m5/params.py <http://reviews.m5sim.org/r/316/#comment701> All this kwargs stuff seems like overkill, and I'm not sure all the corner cases are handled sensibly (passing in args[0] as elseVal for both ip and netmask seems particularly suspect), but now that it's written I guess there's no point in deleting it. A comment that lists all the options for specifying a value would be helpful though. src/python/m5/util/convert.py <http://reviews.m5sim.org/r/316/#comment702> Shouldn't this be "< 256"? (and "< 32" below too?) Didn't you just point out this same bug in some existing code here? - Steve On 2010-11-17 13:54:35, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/316/ > ----------------------------------------------------------- > > (Updated 2010-11-17 13:54:35) > > > Review request for Default. > > > Summary > ------- > > Params: Add parameter types for IP addresses in various forms. > > New parameter forms are: > IP address in the format "a.b.c.d" where a-d are from decimal 0 to 255. > IP address with netmask which is an IP followed by "/n" where n is a netmask > length in bits from decimal 0 to 32. These can also be specified as an > integral IP and netmask passed in separately. > IP address with port which is an IP followed by ":p" where p is a port index > from decimal 0 to 65535. These can also be specified as an integral IP and > port value passed in separately. > > > Diffs > ----- > > src/base/inet.hh 634d88f0dbd4 > src/base/inet.cc 634d88f0dbd4 > src/python/m5/params.py 634d88f0dbd4 > src/python/m5/util/convert.py 634d88f0dbd4 > src/python/swig/inet.i 634d88f0dbd4 > > Diff: http://reviews.m5sim.org/r/316/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
