> On 2010-11-17 19:11:19, Nathan Binkert wrote: > > src/python/m5/params.py, line 814 > > <http://reviews.m5sim.org/r/316/diff/1/?file=5207#file5207line814> > > > > There are already checks in convert for this. Seems odd to have them > > in both places.
Ditto. > On 2010-11-17 19:11:19, Nathan Binkert wrote: > > src/python/m5/params.py, line 700 > > <http://reviews.m5sim.org/r/316/diff/1/?file=5207#file5207line700> > > > > There are already checks in convert for this. Seems odd to do it here > > too. This is for when the values are set explicitly and don't go through convert. It needs to be in convert as well since that can be called in other contexts. I could move the verification functions into convert.py and call them from both places, but they're so short and simple it doesn't seem like it'd be worth it. > On 2010-11-17 19:11:19, Nathan Binkert wrote: > > src/base/inet.cc, line 137 > > <http://reviews.m5sim.org/r/316/diff/1/?file=5206#file5206line137> > > > > This is somewhat backwards as cprintf can take an ostream. I'd make > > operator<< do the right thing with ccprintf and then have string() use it. > > Just like EthAddr. Yeah, doing things this other way around just seemed to go together easier, but I think it's actually a little less efficient too. I'll look at turning it back around. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/316/#review490 ----------------------------------------------------------- On 2010-11-17 13:54:35, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/316/ > ----------------------------------------------------------- > > (Updated 2010-11-17 13:54:35) > > > Review request for Default. > > > Summary > ------- > > Params: Add parameter types for IP addresses in various forms. > > New parameter forms are: > IP address in the format "a.b.c.d" where a-d are from decimal 0 to 255. > IP address with netmask which is an IP followed by "/n" where n is a netmask > length in bits from decimal 0 to 32. These can also be specified as an > integral IP and netmask passed in separately. > IP address with port which is an IP followed by ":p" where p is a port index > from decimal 0 to 65535. These can also be specified as an integral IP and > port value passed in separately. > > > Diffs > ----- > > src/base/inet.hh 634d88f0dbd4 > src/base/inet.cc 634d88f0dbd4 > src/python/m5/params.py 634d88f0dbd4 > src/python/m5/util/convert.py 634d88f0dbd4 > src/python/swig/inet.i 634d88f0dbd4 > > Diff: http://reviews.m5sim.org/r/316/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
