> On 2010-11-20 09:35:35, Ali Saidi wrote: > > src/python/m5/util/convert.py, line 283 > > <http://reviews.m5sim.org/r/316/diff/3/?file=5371#file5371line283> > > > > Why hex for max port here and decimal for max byte above?
It was arbitrary. It looks like everything else uses hex values so I'll standardize on that. > On 2010-11-20 09:35:35, Ali Saidi wrote: > > src/python/m5/util/convert.py, line 267 > > <http://reviews.m5sim.org/r/316/diff/3/?file=5371#file5371line267> > > > > I net mask could also be specified like 10.3.4.5/255.255.0.0. Perhaps > > handling that case would be good too. Minimally, I think the /16 should be > > converted to the long form netmask and that should be passed around. It would be a good idea to recognize the long form, but I think the short form should be passed around. It's a lot easier to reliably go from short to long than the other way. - Gabe ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/316/#review495 ----------------------------------------------------------- On 2010-11-19 14:21:03, Gabe Black wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/316/ > ----------------------------------------------------------- > > (Updated 2010-11-19 14:21:03) > > > Review request for Default. > > > Summary > ------- > > Params: Add parameter types for IP addresses in various forms. > > New parameter forms are: > IP address in the format "a.b.c.d" where a-d are from decimal 0 to 255. > IP address with netmask which is an IP followed by "/n" where n is a netmask > length in bits from decimal 0 to 32. These can also be specified as an > integral IP and netmask passed in separately. > IP address with port which is an IP followed by ":p" where p is a port index > from decimal 0 to 65535. These can also be specified as an integral IP and > port value passed in separately. > > > Diffs > ----- > > src/base/inet.hh bf5377d8f5c1 > src/base/inet.cc bf5377d8f5c1 > src/python/m5/params.py bf5377d8f5c1 > src/python/m5/util/convert.py bf5377d8f5c1 > src/python/swig/inet.i bf5377d8f5c1 > > Diff: http://reviews.m5sim.org/r/316/diff > > > Testing > ------- > > > Thanks, > > Gabe > >
_______________________________________________ m5-dev mailing list [email protected] http://m5sim.org/mailman/listinfo/m5-dev
